Re: [PATCH 2/2] xen: do not use '%ms' scanf specifier

2025-01-10 Thread David Woodhouse
On Fri, 2025-01-10 at 09:16 +0100, Philippe Mathieu-Daudé wrote: > On 10/1/25 09:08, David Woodhouse wrote: > > On Thu, 2025-01-09 at 17:55 +0100, Roger Pau Monné wrote: > > > On Thu, Jan 09, 2025 at 11:25:13AM +, David Woodhouse wrote: > > > > On Thu, 2025-01-09 at 11:59 +0100, Anthony PERARD

Re: [PATCH 2/2] xen: do not use '%ms' scanf specifier

2025-01-10 Thread Philippe Mathieu-Daudé
On 10/1/25 09:08, David Woodhouse wrote: On Thu, 2025-01-09 at 17:55 +0100, Roger Pau Monné wrote: On Thu, Jan 09, 2025 at 11:25:13AM +, David Woodhouse wrote: On Thu, 2025-01-09 at 11:59 +0100, Anthony PERARD wrote:   char label[32];   XenDevice *xendev = NULL;   XenConso

Re: [PATCH 2/2] xen: do not use '%ms' scanf specifier

2025-01-10 Thread David Woodhouse
On Thu, 2025-01-09 at 17:55 +0100, Roger Pau Monné wrote: > On Thu, Jan 09, 2025 at 11:25:13AM +, David Woodhouse wrote: > > On Thu, 2025-01-09 at 11:59 +0100, Anthony PERARD wrote: > > > > > > >   char label[32]; > > > >   XenDevice *xendev = NULL; > > > >   XenConsole *con; > > >

Re: [PATCH 2/2] xen: do not use '%ms' scanf specifier

2025-01-09 Thread Roger Pau Monné
On Thu, Jan 09, 2025 at 11:25:13AM +, David Woodhouse wrote: > On Thu, 2025-01-09 at 11:59 +0100, Anthony PERARD wrote: > > > > >   char label[32]; > > >   XenDevice *xendev = NULL; > > >   XenConsole *con; > > > @@ -550,7 +551,10 @@ static void > > > xen_console_device_create(Xen

Re: [PATCH 2/2] xen: do not use '%ms' scanf specifier

2025-01-09 Thread Roger Pau Monné
On Thu, Jan 09, 2025 at 11:59:48AM +0100, Anthony PERARD wrote: > On Tue, Jan 07, 2025 at 10:31:40AM +0100, Roger Pau Monne wrote: > > The 'm' parameter used to request auto-allocation of the destination > > variable > > is not supported on FreeBSD, and as such leads to failures to parse. > > > >

Re: [PATCH 2/2] xen: do not use '%ms' scanf specifier

2025-01-09 Thread David Woodhouse
On Thu, 2025-01-09 at 11:59 +0100, Anthony PERARD wrote: > > >   char label[32]; > >   XenDevice *xendev = NULL; > >   XenConsole *con; > > @@ -550,7 +551,10 @@ static void > > xen_console_device_create(XenBackendInstance *backend, > >   goto fail; > >   } > >   > > -   

Re: [PATCH 2/2] xen: do not use '%ms' scanf specifier

2025-01-09 Thread Anthony PERARD
On Tue, Jan 07, 2025 at 10:31:40AM +0100, Roger Pau Monne wrote: > The 'm' parameter used to request auto-allocation of the destination variable > is not supported on FreeBSD, and as such leads to failures to parse. > > What's more, the current usage of '%ms' with xs_node_scanf() is pointless, as

[PATCH 2/2] xen: do not use '%ms' scanf specifier

2025-01-07 Thread Roger Pau Monne
The 'm' parameter used to request auto-allocation of the destination variable is not supported on FreeBSD, and as such leads to failures to parse. What's more, the current usage of '%ms' with xs_node_scanf() is pointless, as it just leads to a double allocation of the same string. Instead use qem