Re: [PATCH 2/2] virtio-net: add missing object_unref()

2021-02-09 Thread Laurent Vivier
CC: Michael On 06/02/2021 13:39, Laurent Vivier wrote: > failover_add_primary() calls qdev_device_add() and doesn't unref > the device. Because of that, when the device is unplugged a reference > is remaining and prevents the cleanup of the object. > > This prevents to be able to plugin back the

Re: [PATCH 2/2] virtio-net: add missing object_unref()

2021-02-08 Thread Jens Freimann
On Sat, Feb 06, 2021 at 01:39:55PM +0100, Laurent Vivier wrote: failover_add_primary() calls qdev_device_add() and doesn't unref the device. Because of that, when the device is unplugged a reference is remaining and prevents the cleanup of the object. This prevents to be able to plugin back the

[PATCH 2/2] virtio-net: add missing object_unref()

2021-02-06 Thread Laurent Vivier
failover_add_primary() calls qdev_device_add() and doesn't unref the device. Because of that, when the device is unplugged a reference is remaining and prevents the cleanup of the object. This prevents to be able to plugin back the failover primary device, with errors like: (qemu) device_add v