Re: [PATCH 2/2] tools: Fix use of fcntl(F_SETFD) during socket activation

2020-04-21 Thread Eric Blake
On 4/20/20 12:53 PM, Eric Blake wrote: Blindly setting FD_CLOEXEC without a read-modify-write will inadvertently clear any other intentionally-set bits, such as a proposed new bit for designating a fd that must behave in 32-bit mode. However, we cannot use our wrapper qemu_set_cloexec(), because

[PATCH 2/2] tools: Fix use of fcntl(F_SETFD) during socket activation

2020-04-20 Thread Eric Blake
Blindly setting FD_CLOEXEC without a read-modify-write will inadvertently clear any other intentionally-set bits, such as a proposed new bit for designating a fd that must behave in 32-bit mode. However, we cannot use our wrapper qemu_set_cloexec(), because that wrapper intentionally abort()s on fa