Re: [PATCH 2/2] test-keyval: Tighten test of trailing crap after size

2019-12-18 Thread Laurent Vivier
Le 25/11/2019 à 14:38, Markus Armbruster a écrit : > test_keyval_visit_size() should test for trailing crap after size with > and without suffix. It does test the latter: "sz2=16Gi" has size > "16G" followed by crap "i". It fails to test the former "sz1=16E" is > a syntactically valid size that o

Re: [PATCH 2/2] test-keyval: Tighten test of trailing crap after size

2019-11-25 Thread Eric Blake
On 11/25/19 9:31 AM, Markus Armbruster wrote: Eric Blake writes: On 11/25/19 7:38 AM, Markus Armbruster wrote: test_keyval_visit_size() should test for trailing crap after size with and without suffix. It does test the latter: "sz2=16Gi" has size "16G" followed by crap "i". It fails to test

Re: [PATCH 2/2] test-keyval: Tighten test of trailing crap after size

2019-11-25 Thread Markus Armbruster
Eric Blake writes: > On 11/25/19 7:38 AM, Markus Armbruster wrote: >> test_keyval_visit_size() should test for trailing crap after size with >> and without suffix. It does test the latter: "sz2=16Gi" has size >> "16G" followed by crap "i". It fails to test the former "sz1=16E" is >> a syntactic

Re: [PATCH 2/2] test-keyval: Tighten test of trailing crap after size

2019-11-25 Thread Eric Blake
On 11/25/19 7:38 AM, Markus Armbruster wrote: test_keyval_visit_size() should test for trailing crap after size with and without suffix. It does test the latter: "sz2=16Gi" has size "16G" followed by crap "i". It fails to test the former "sz1=16E" is a syntactically valid size that overflows ui

[PATCH 2/2] test-keyval: Tighten test of trailing crap after size

2019-11-25 Thread Markus Armbruster
test_keyval_visit_size() should test for trailing crap after size with and without suffix. It does test the latter: "sz2=16Gi" has size "16G" followed by crap "i". It fails to test the former "sz1=16E" is a syntactically valid size that overflows uint64_t. Replace by "sz1=0Z". Signed-off-by: Ma