Re: [PATCH 2/2] pci: Sanity check mask argument to pci_set_*_by_mask()

2022-08-17 Thread Peter Maydell
On Wed, 17 Aug 2022 at 11:48, Michael S. Tsirkin wrote: > > On Wed, Jul 27, 2022 at 11:26:15AM +0100, Peter Maydell wrote: > > On Tue, 26 Jul 2022 at 23:30, Richard Henderson > > wrote: > > > > > > On 7/26/22 09:32, Peter Maydell wrote: > > > > Coverity complains that in functions like pci_set_wo

Re: [PATCH 2/2] pci: Sanity check mask argument to pci_set_*_by_mask()

2022-08-17 Thread Michael S. Tsirkin
On Wed, Jul 27, 2022 at 11:26:15AM +0100, Peter Maydell wrote: > On Tue, 26 Jul 2022 at 23:30, Richard Henderson > wrote: > > > > On 7/26/22 09:32, Peter Maydell wrote: > > > Coverity complains that in functions like pci_set_word_by_mask() > > > we might end up shifting by more than 31 bits. This

Re: [PATCH 2/2] pci: Sanity check mask argument to pci_set_*_by_mask()

2022-07-27 Thread Peter Maydell
On Tue, 26 Jul 2022 at 23:30, Richard Henderson wrote: > > On 7/26/22 09:32, Peter Maydell wrote: > > Coverity complains that in functions like pci_set_word_by_mask() > > we might end up shifting by more than 31 bits. This is true, > > but only if the caller passes in a zero mask. Help Coverity ou

Re: [PATCH 2/2] pci: Sanity check mask argument to pci_set_*_by_mask()

2022-07-26 Thread Richard Henderson
On 7/26/22 09:32, Peter Maydell wrote: Coverity complains that in functions like pci_set_word_by_mask() we might end up shifting by more than 31 bits. This is true, but only if the caller passes in a zero mask. Help Coverity out by asserting that the mask argument is valid. Fixes: CID 1487168 S

Re: [PATCH 2/2] pci: Sanity check mask argument to pci_set_*_by_mask()

2022-07-26 Thread Philippe Mathieu-Daudé via
On 26/7/22 18:32, Peter Maydell wrote: Coverity complains that in functions like pci_set_word_by_mask() we might end up shifting by more than 31 bits. This is true, but only if the caller passes in a zero mask. Help Coverity out by asserting that the mask argument is valid. Fixes: CID 1487168 S

[PATCH 2/2] pci: Sanity check mask argument to pci_set_*_by_mask()

2022-07-26 Thread Peter Maydell
Coverity complains that in functions like pci_set_word_by_mask() we might end up shifting by more than 31 bits. This is true, but only if the caller passes in a zero mask. Help Coverity out by asserting that the mask argument is valid. Fixes: CID 1487168 Signed-off-by: Peter Maydell --- Note tha