Re: [PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP

2025-02-12 Thread Vladimir Sementsov-Ogievskiy
On 11.02.25 00:46, Eric Blake wrote: On Thu, Feb 06, 2025 at 10:20:09AM +0300, Vladimir Sementsov-Ogievskiy wrote: --- qapi/block-export.json | 10 ++ include/block/nbd.h| 6 +++--- [..] @@ -52,6 +57,10 @@ # # @addr: Address on which to listen. # +#

Re: [PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP

2025-02-10 Thread Eric Blake
On Thu, Feb 06, 2025 at 10:20:09AM +0300, Vladimir Sementsov-Ogievskiy wrote: > > --- > > qapi/block-export.json | 10 ++ > > include/block/nbd.h| 6 +++--- > > [..] > > > @@ -52,6 +57,10 @@ > > # > > # @addr: Address on which to listen. > > # > > +# @handshak

Re: [PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP

2025-02-05 Thread Vladimir Sementsov-Ogievskiy
On 04.02.25 01:26, Eric Blake wrote: Although defaulting the handshake limit to 10 seconds was a nice QoI change to weed out intentionally slow clients, it can interfere with integration testing done with manual NBD_OPT commands over 'nbdsh --opt-mode'. Expose a QMP knob 'handshake-max-secs' to

Re: [PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP

2025-02-05 Thread Markus Armbruster
Eric Blake writes: > On Wed, Feb 05, 2025 at 07:55:56AM +0100, Markus Armbruster wrote: >> Eric Blake writes: >> >> > Although defaulting the handshake limit to 10 seconds was a nice QoI >> > change to weed out intentionally slow clients, it can interfere with >> > integration testing done with

Re: [PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP

2025-02-05 Thread Eric Blake
On Wed, Feb 05, 2025 at 07:55:56AM +0100, Markus Armbruster wrote: > Eric Blake writes: > > > Although defaulting the handshake limit to 10 seconds was a nice QoI > > change to weed out intentionally slow clients, it can interfere with > > integration testing done with manual NBD_OPT commands ove

Re: [PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP

2025-02-04 Thread Markus Armbruster
Eric Blake writes: > Although defaulting the handshake limit to 10 seconds was a nice QoI > change to weed out intentionally slow clients, it can interfere with > integration testing done with manual NBD_OPT commands over 'nbdsh > --opt-mode'. Expose a QMP knob 'handshake-max-secs' to allow the

[PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP

2025-02-03 Thread Eric Blake
Although defaulting the handshake limit to 10 seconds was a nice QoI change to weed out intentionally slow clients, it can interfere with integration testing done with manual NBD_OPT commands over 'nbdsh --opt-mode'. Expose a QMP knob 'handshake-max-secs' to allow the user to alter the timeout awa

Re: [PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP

2024-10-02 Thread Eric Blake
On Wed, Oct 02, 2024 at 05:14:42PM GMT, Markus Armbruster wrote: > >> Are we confident we'll never need less than a full second? > > > > Hmm, recent "[PATCH v2] chardev: introduce 'reconnect-ms' and deprecate > > 'reconnect'" shows that at least sometimes second is not enough precision. > > > > Ma

Re: [PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP

2024-10-02 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > On 02.10.24 16:49, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Although defaulting the handshake limit to 10 seconds was a nice QoI >>> change to weed out intentionally slow clients, it can interfere with >>> integration testing done with manual

Re: [PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP

2024-10-02 Thread Vladimir Sementsov-Ogievskiy
On 02.10.24 16:49, Markus Armbruster wrote: Eric Blake writes: Although defaulting the handshake limit to 10 seconds was a nice QoI change to weed out intentionally slow clients, it can interfere with integration testing done with manual NBD_OPT commands over 'nbdsh --opt-mode'. Expose a QMP

Re: [PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP

2024-10-02 Thread Markus Armbruster
Eric Blake writes: > Although defaulting the handshake limit to 10 seconds was a nice QoI > change to weed out intentionally slow clients, it can interfere with > integration testing done with manual NBD_OPT commands over 'nbdsh > --opt-mode'. Expose a QMP knob 'handshake-max-secs' to allow the

Re: [PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP

2024-10-02 Thread Vladimir Sementsov-Ogievskiy
On 09.08.24 19:14, Eric Blake wrote: Although defaulting the handshake limit to 10 seconds was a nice QoI change to weed out intentionally slow clients, it can interfere with integration testing done with manual NBD_OPT commands over 'nbdsh --opt-mode'. Expose a QMP knob 'handshake-max-secs' to

[PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP

2024-08-09 Thread Eric Blake
Although defaulting the handshake limit to 10 seconds was a nice QoI change to weed out intentionally slow clients, it can interfere with integration testing done with manual NBD_OPT commands over 'nbdsh --opt-mode'. Expose a QMP knob 'handshake-max-secs' to allow the user to alter the timeout awa