Re: [PATCH 2/2] mmap-alloc: Include osdep.h before checking CONFIG_LINUX

2020-03-11 Thread Michael S. Tsirkin
On Wed, Mar 11, 2020 at 06:51:30PM -0400, Eduardo Habkost wrote: > The CONFIG_LINUX check at the top of mmap-alloc.c never worked > because it was done before including osdep.h. > > This means MAP_SYNC and MAP_SHARED_VALIDATE would always be set > to 0 at the beginning of the file. Luckily, this

[PATCH 2/2] mmap-alloc: Include osdep.h before checking CONFIG_LINUX

2020-03-11 Thread Eduardo Habkost
The CONFIG_LINUX check at the top of mmap-alloc.c never worked because it was done before including osdep.h. This means MAP_SYNC and MAP_SHARED_VALIDATE would always be set to 0 at the beginning of the file. Luckily, this didn't break when using recent glibc versions (2.28+), because those macros