Re: [PATCH 2/2] hw/riscv/riscv-iommu: fix riscv_iommu_validate_process_ctx() check

2024-11-04 Thread Alistair Francis
On Mon, Nov 4, 2024 at 10:40 PM Daniel Henrique Barboza wrote: > > 'mode' will never be RISCV_IOMMU_CAP_SV32. We are erroring out in the > 'switch' right before it if 'mode' isn't 0, 8, 9 or 10. > > 'mode' should be check with RISCV_IOMMU_DC_FSC_IOSATP_MODE_SV32. > > Reported by Coverity via a "DE

[PATCH 2/2] hw/riscv/riscv-iommu: fix riscv_iommu_validate_process_ctx() check

2024-11-04 Thread Daniel Henrique Barboza
'mode' will never be RISCV_IOMMU_CAP_SV32. We are erroring out in the 'switch' right before it if 'mode' isn't 0, 8, 9 or 10. 'mode' should be check with RISCV_IOMMU_DC_FSC_IOSATP_MODE_SV32. Reported by Coverity via a "DEADCODE" ticket. Resolves: Coverity CID 1564781 Fixes: 0c54acb8243 ("hw/risc