Re: [PATCH 2/2] hw/arm/aspeed: add Bletchley machine type

2022-03-08 Thread Joel Stanley
On Tue, 8 Mar 2022 at 17:23, Patrick Williams wrote: > > On Tue, Mar 08, 2022 at 09:14:07AM +0100, Cédric Le Goater wrote: > > > > >> There are two flash devices on the FMC. I can fix it inline since > > >> it is the only change I would request. > > > > > > Yes, there are. I think all of the Face

Re: [PATCH 2/2] hw/arm/aspeed: add Bletchley machine type

2022-03-08 Thread Patrick Williams
On Tue, Mar 08, 2022 at 09:14:07AM +0100, Cédric Le Goater wrote: > > >> There are two flash devices on the FMC. I can fix it inline since > >> it is the only change I would request. > > > > Yes, there are. I think all of the Facebook systems have dual FMC, for > > redundancy in hardware, but we

Re: [PATCH 2/2] hw/arm/aspeed: add Bletchley machine type

2022-03-08 Thread Cédric Le Goater
There are two flash devices on the FMC. I can fix it inline since it is the only change I would request. Yes, there are. I think all of the Facebook systems have dual FMC, for redundancy in hardware, but we can get by in QEMU with just a single one. yes, the kernel will complain though and

Re: [PATCH 2/2] hw/arm/aspeed: add Bletchley machine type

2022-03-04 Thread Cédric Le Goater
On 3/5/22 01:06, Patrick Williams wrote: Add the 'bletchley-bmc' machine type based on the kernel DTS[1] and hardware schematics available to me. The i2c model is as complete as the current QEMU models support, but in some cases I substituted devices that are close enough for present functionali

[PATCH 2/2] hw/arm/aspeed: add Bletchley machine type

2022-03-04 Thread Patrick Williams
Add the 'bletchley-bmc' machine type based on the kernel DTS[1] and hardware schematics available to me. The i2c model is as complete as the current QEMU models support, but in some cases I substituted devices that are close enough for present functionality. Strap registers are kept the same as t