Re: [PATCH 2/2] e1000e: make TX reentrant

2020-07-23 Thread Jason Wang
On 2020/7/23 下午6:36, Peter Maydell wrote: On Wed, 22 Jul 2020 at 10:00, Jason Wang wrote: In loopback mode, e1000e RX can DMA into TX doorbell which requires TX to be reentrant. This patch make e1000e's TX routine reentrant by introducing a per device boolean for recording whether or not a TX

Re: [PATCH 2/2] e1000e: make TX reentrant

2020-07-23 Thread Stefan Hajnoczi
On Thu, Jul 23, 2020 at 10:25:35AM +0800, Jason Wang wrote: > > On 2020/7/22 下午8:53, Michael Tokarev wrote: > > FWIW, this is not "making TX reentrant", it is about forbidding > > reentrancy instead :) > > > > /mjt > > > Indeed, I will rename the title. Please also include a comment explaining

Re: [PATCH 2/2] e1000e: make TX reentrant

2020-07-23 Thread Peter Maydell
On Wed, 22 Jul 2020 at 10:00, Jason Wang wrote: > > In loopback mode, e1000e RX can DMA into TX doorbell which requires > TX to be reentrant. This patch make e1000e's TX routine reentrant by > introducing a per device boolean for recording whether or not a TX > rountine is being called and return

Re: [PATCH 2/2] e1000e: make TX reentrant

2020-07-22 Thread Jason Wang
On 2020/7/22 下午8:53, Michael Tokarev wrote: FWIW, this is not "making TX reentrant", it is about forbidding reentrancy instead :) /mjt Indeed, I will rename the title. Thanks

Re: [PATCH 2/2] e1000e: make TX reentrant

2020-07-22 Thread Jason Wang
On 2020/7/22 下午7:24, Li Qiang wrote: Jason Wang 于2020年7月22日周三 下午4:58写道: In loopback mode, e1000e RX can DMA into TX doorbell which requires TX to be reentrant. This patch make e1000e's TX routine reentrant by introducing a per device boolean for recording whether or not a TX rountine is being

Re: [PATCH 2/2] e1000e: make TX reentrant

2020-07-22 Thread Michael Tokarev
FWIW, this is not "making TX reentrant", it is about forbidding reentrancy instead :) /mjt

Re: [PATCH 2/2] e1000e: make TX reentrant

2020-07-22 Thread Li Qiang
Jason Wang 于2020年7月22日周三 下午4:58写道: > > In loopback mode, e1000e RX can DMA into TX doorbell which requires > TX to be reentrant. This patch make e1000e's TX routine reentrant by > introducing a per device boolean for recording whether or not a TX > rountine is being called and return early. > Cou

[PATCH 2/2] e1000e: make TX reentrant

2020-07-22 Thread Jason Wang
In loopback mode, e1000e RX can DMA into TX doorbell which requires TX to be reentrant. This patch make e1000e's TX routine reentrant by introducing a per device boolean for recording whether or not a TX rountine is being called and return early. Signed-off-by: Jason Wang --- hw/net/e1000e_core.