Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-16 Thread Guoheyi
在 2020/1/16 20:24, Peter Maydell 写道: On Wed, 15 Jan 2020 at 10:55, Michael S. Tsirkin wrote: Here's a hopefully better patch. Peter does this address the issue? Signed-off-by: Michael S. Tsirkin diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index f1ac2d7e96.

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-16 Thread Guoheyi
在 2020/1/16 21:25, Igor Mammedov 写道: On Thu, 16 Jan 2020 19:56:19 +0800 Guoheyi wrote: 在 2020/1/5 20:53, Michael S. Tsirkin 写道: On Sun, Jan 05, 2020 at 07:34:01AM -0500, Michael S. Tsirkin wrote: On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote: According to ACPI spec, _ADR should

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-16 Thread Igor Mammedov
On Thu, 16 Jan 2020 19:56:19 +0800 Guoheyi wrote: > 在 2020/1/5 20:53, Michael S. Tsirkin 写道: > > On Sun, Jan 05, 2020 at 07:34:01AM -0500, Michael S. Tsirkin wrote: > >> On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote: > >>> According to ACPI spec, _ADR should be used for device whic

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-16 Thread Peter Maydell
On Wed, 15 Jan 2020 at 10:55, Michael S. Tsirkin wrote: > > Here's a hopefully better patch. Peter does this address the issue? > > Signed-off-by: Michael S. Tsirkin > > > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c > index f1ac2d7e96..3ab4872bd7 100644 > --- a/te

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-16 Thread Guoheyi
在 2020/1/5 20:53, Michael S. Tsirkin 写道: On Sun, Jan 05, 2020 at 07:34:01AM -0500, Michael S. Tsirkin wrote: On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote: According to ACPI spec, _ADR should be used for device which is on a bus that has a standard enumeration algorithm. It does no

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-15 Thread Igor Mammedov
On Thu, 19 Dec 2019 14:47:59 +0800 Heyi Guo wrote: > According to ACPI spec, _ADR should be used for device which is on a > bus that has a standard enumeration algorithm. It does not make sense > to have a _ADR object for devices which already have _HID and will be > enumerated by OSPM. > > Sign

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-15 Thread Michael S. Tsirkin
On Wed, Jan 15, 2020 at 05:25:50PM +0800, Guoheyi wrote: > > 在 2020/1/15 14:30, Michael S. Tsirkin 写道: > > Problem is IASL disassembler still doesn't work on all hosts > > we want to support. And its output isn't really stable enough > > to act as a golden master. > > > > Until we have a better t

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-15 Thread Michael S. Tsirkin
On Wed, Jan 15, 2020 at 05:25:50PM +0800, Guoheyi wrote: > > 在 2020/1/15 14:30, Michael S. Tsirkin 写道: > > Problem is IASL disassembler still doesn't work on all hosts > > we want to support. And its output isn't really stable enough > > to act as a golden master. > > > > Until we have a better t

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-15 Thread Guoheyi
在 2020/1/15 14:30, Michael S. Tsirkin 写道: Problem is IASL disassembler still doesn't work on all hosts we want to support. And its output isn't really stable enough to act as a golden master. Until we have a better tool, I propose the contributor just follows all steps 1-6. The reason they ha

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-14 Thread Michael S. Tsirkin
Problem is IASL disassembler still doesn't work on all hosts we want to support. And its output isn't really stable enough to act as a golden master. Until we have a better tool, I propose the contributor just follows all steps 1-6. The reason they have been listed as maintainer action items is

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-14 Thread Guoheyi
Hi Peter, Michael, Have we come to conclusion on how to submit patches for ARM ACPI tables? Some rough thoughts: is it possible to use the disassembled ASL file as the 'golden master' data? One problem I can imagine is that this may introduce dependency on the version of iASL tool. If so, how

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-14 Thread Guoheyi
在 2020/1/13 23:26, Andrew Jones 写道: On Mon, Jan 13, 2020 at 09:57:55PM +0800, Guoheyi wrote: 在 2020/1/13 20:08, Igor Mammedov 写道: On Thu, 19 Dec 2019 14:47:59 +0800 Heyi Guo wrote: According to ACPI spec, _ADR should be used for device which is on a bus that has a standard enumeration algo

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-13 Thread Andrew Jones
On Mon, Jan 13, 2020 at 09:57:55PM +0800, Guoheyi wrote: > > 在 2020/1/13 20:08, Igor Mammedov 写道: > > On Thu, 19 Dec 2019 14:47:59 +0800 > > Heyi Guo wrote: > > > > > According to ACPI spec, _ADR should be used for device which is on a > > > bus that has a standard enumeration algorithm. It does

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-13 Thread Guoheyi
在 2020/1/13 20:08, Igor Mammedov 写道: On Thu, 19 Dec 2019 14:47:59 +0800 Heyi Guo wrote: According to ACPI spec, _ADR should be used for device which is on a bus that has a standard enumeration algorithm. It does not make sense to have a _ADR object for devices which already have _HID and wil

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-13 Thread Igor Mammedov
On Thu, 19 Dec 2019 14:47:59 +0800 Heyi Guo wrote: > According to ACPI spec, _ADR should be used for device which is on a > bus that has a standard enumeration algorithm. It does not make sense > to have a _ADR object for devices which already have _HID and will be > enumerated by OSPM. > > Sign

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-13 Thread Guoheyi
Hi Michael, Any more comments? Or shall I refine the commit message? Thanks, Heyi 在 2020/1/6 10:10, Guoheyi 写道: 在 2020/1/5 20:53, Michael S. Tsirkin 写道: On Sun, Jan 05, 2020 at 07:34:01AM -0500, Michael S. Tsirkin wrote: On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote: According

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-06 Thread Peter Maydell
On Sun, 5 Jan 2020 at 12:34, Michael S. Tsirkin wrote: > > On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote: > > hw/arm/virt-acpi-build.c | 8 > > tests/data/acpi/virt/DSDT | Bin 18449 -> 18426 bytes > > tests/data/acpi/virt/DSDT.memhp | Bin 19786 -> 19763

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-06 Thread Corey Minyard
On Mon, Jan 06, 2020 at 04:39:51AM -0500, Michael S. Tsirkin wrote: > On Sun, Jan 05, 2020 at 04:54:20PM -0600, Corey Minyard wrote: > > On Sun, Jan 05, 2020 at 07:33:55AM -0500, Michael S. Tsirkin wrote: > > > On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote: > > > > According to ACPI spec

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-06 Thread Michael S. Tsirkin
On Sun, Jan 05, 2020 at 04:54:20PM -0600, Corey Minyard wrote: > On Sun, Jan 05, 2020 at 07:33:55AM -0500, Michael S. Tsirkin wrote: > > On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote: > > > According to ACPI spec, _ADR should be used for device which is on a > > > bus that has a standard

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-05 Thread Guoheyi
在 2020/1/5 20:53, Michael S. Tsirkin 写道: On Sun, Jan 05, 2020 at 07:34:01AM -0500, Michael S. Tsirkin wrote: On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote: According to ACPI spec, _ADR should be used for device which is on a bus that has a standard enumeration algorithm. It does no

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-05 Thread Corey Minyard
On Sun, Jan 05, 2020 at 07:33:55AM -0500, Michael S. Tsirkin wrote: > On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote: > > According to ACPI spec, _ADR should be used for device which is on a > > bus that has a standard enumeration algorithm. It does not make sense > > to have a _ADR objec

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-05 Thread Michael S. Tsirkin
On Sun, Jan 05, 2020 at 07:34:01AM -0500, Michael S. Tsirkin wrote: > On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote: > > According to ACPI spec, _ADR should be used for device which is on a > > bus that has a standard enumeration algorithm. It does not make sense > > to have a _ADR objec

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-05 Thread Michael S. Tsirkin
On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote: > According to ACPI spec, _ADR should be used for device which is on a > bus that has a standard enumeration algorithm. It does not make sense > to have a _ADR object for devices which already have _HID and will be > enumerated by OSPM. > >

[PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2019-12-18 Thread Heyi Guo
According to ACPI spec, _ADR should be used for device which is on a bus that has a standard enumeration algorithm. It does not make sense to have a _ADR object for devices which already have _HID and will be enumerated by OSPM. Signed-off-by: Heyi Guo --- Cc: Shannon Zhao Cc: Peter Maydell Cc