Re: [PATCH 2/2] add maximum combined fw size as machine configuration option

2020-09-22 Thread Laszlo Ersek
On 09/18/20 10:31, Daniel P. Berrangé wrote: > On Fri, Sep 18, 2020 at 04:23:39AM +, Erich Mcmillan wrote: >> From: Erich McMillan >> >> Signed-off-by: Erich McMillan >> --- >> hw/i386/pc.c | 40 >> hw/i386/pc_sysfw.c | 13 ++--- >>

Re: [PATCH 2/2] add maximum combined fw size as machine configuration option

2020-09-22 Thread Laszlo Ersek
On 09/18/20 10:17, Philippe Mathieu-Daudé wrote: > I'm very confused by pc_system_flash_map()... Why not check > that no pflash exceeds 8MiB? Then 2 combined would be always > <16MiB. The requirement (limit) is on the total address range that is occupied by the flash chips that are mapped in sequ

Re: [PATCH 2/2] add maximum combined fw size as machine configuration option

2020-09-18 Thread Daniel P . Berrangé
On Fri, Sep 18, 2020 at 04:23:39AM +, Erich Mcmillan wrote: > From: Erich McMillan > > Signed-off-by: Erich McMillan > --- > hw/i386/pc.c | 40 > hw/i386/pc_sysfw.c | 13 ++--- > include/hw/i386/pc.h | 22 -- > 3

Re: [PATCH 2/2] add maximum combined fw size as machine configuration option

2020-09-18 Thread Philippe Mathieu-Daudé
Hi Erich, On 9/18/20 6:23 AM, Erich Mcmillan wrote: > From: Erich McMillan Description/rationale? > > Signed-off-by: Erich McMillan > --- > hw/i386/pc.c | 40 > hw/i386/pc_sysfw.c | 13 ++--- > include/hw/i386/pc.h | 22 -

[PATCH 2/2] add maximum combined fw size as machine configuration option

2020-09-17 Thread Erich Mcmillan
From: Erich McMillan Signed-off-by: Erich McMillan --- hw/i386/pc.c | 40 hw/i386/pc_sysfw.c | 13 ++--- include/hw/i386/pc.h | 22 -- 3 files changed, 54 insertions(+), 21 deletions(-) diff --git a/hw/i386/pc.c b/h