Re: [PATCH 19/36] qdev: Move array property creation/registration to separate functions

2020-10-30 Thread Eduardo Habkost
On Fri, Oct 30, 2020 at 02:03:07PM +0400, Marc-André Lureau wrote: > On Fri, Oct 30, 2020 at 2:17 AM Eduardo Habkost wrote: > > > The array property registration code is hard to follow. Move the > > two steps into separate functions that have clear > > responsibilities. > > > > Signed-off-by: Ed

Re: [PATCH 19/36] qdev: Move array property creation/registration to separate functions

2020-10-30 Thread Daniel P . Berrangé
On Fri, Oct 30, 2020 at 02:10:26PM +0400, Marc-André Lureau wrote: > On Fri, Oct 30, 2020 at 2:03 PM Marc-André Lureau < > marcandre.lur...@gmail.com> wrote: > > > > > > > On Fri, Oct 30, 2020 at 2:17 AM Eduardo Habkost > > wrote: > > > >> The array property registration code is hard to follow.

Re: [PATCH 19/36] qdev: Move array property creation/registration to separate functions

2020-10-30 Thread Marc-André Lureau
On Fri, Oct 30, 2020 at 2:03 PM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > > > On Fri, Oct 30, 2020 at 2:17 AM Eduardo Habkost > wrote: > >> The array property registration code is hard to follow. Move the >> two steps into separate functions that have clear >> responsibilities. >>

Re: [PATCH 19/36] qdev: Move array property creation/registration to separate functions

2020-10-30 Thread Marc-André Lureau
On Fri, Oct 30, 2020 at 2:17 AM Eduardo Habkost wrote: > The array property registration code is hard to follow. Move the > two steps into separate functions that have clear > responsibilities. > > Signed-off-by: Eduardo Habkost > --- > Cc: Paolo Bonzini > Cc: "Daniel P. Berrangé" > Cc: Eduar

[PATCH 19/36] qdev: Move array property creation/registration to separate functions

2020-10-29 Thread Eduardo Habkost
The array property registration code is hard to follow. Move the two steps into separate functions that have clear responsibilities. Signed-off-by: Eduardo Habkost --- Cc: Paolo Bonzini Cc: "Daniel P. Berrangé" Cc: Eduardo Habkost Cc: qemu-devel@nongnu.org --- hw/core/qdev-properties.c | 60