Re: [PATCH 19/25] qapi: Improve reporting of invalid flags

2019-09-24 Thread Markus Armbruster
Markus Armbruster writes: > Eric Blake writes: > >> On 9/24/19 8:28 AM, Markus Armbruster wrote: >>> Split check_flags() off check_keys() and have check_exprs() call it >>> later, so its error messages gain an "in definition" line. Tweak the >>> error messages. >>> >>> Checking values in a fun

Re: [PATCH 19/25] qapi: Improve reporting of invalid flags

2019-09-24 Thread Markus Armbruster
Eric Blake writes: > On 9/24/19 8:28 AM, Markus Armbruster wrote: >> Split check_flags() off check_keys() and have check_exprs() call it >> later, so its error messages gain an "in definition" line. Tweak the >> error messages. >> >> Checking values in a function named check_keys() is unclean a

Re: [PATCH 19/25] qapi: Improve reporting of invalid flags

2019-09-24 Thread Eric Blake
On 9/24/19 8:28 AM, Markus Armbruster wrote: > Split check_flags() off check_keys() and have check_exprs() call it > later, so its error messages gain an "in definition" line. Tweak the > error messages. > > Checking values in a function named check_keys() is unclean anyway. > > Signed-off-by: M

[PATCH 19/25] qapi: Improve reporting of invalid flags

2019-09-24 Thread Markus Armbruster
Split check_flags() off check_keys() and have check_exprs() call it later, so its error messages gain an "in definition" line. Tweak the error messages. Checking values in a function named check_keys() is unclean anyway. Signed-off-by: Markus Armbruster --- scripts/qapi/common.py