Re: [PATCH 19/23] accel/tcg: Always use IntervalTree for code lookups

2024-10-11 Thread Pierrick Bouvier
On 10/11/24 07:47, Richard Henderson wrote: On 10/9/24 17:35, Pierrick Bouvier wrote: @@ -1061,15 +1061,13 @@ static inline void tlb_set_compare(CPUTLBEntryFull *full, CPUTLBEntry *ent, vaddr address, int flags, MMUAcce

Re: [PATCH 19/23] accel/tcg: Always use IntervalTree for code lookups

2024-10-11 Thread Richard Henderson
On 10/9/24 17:35, Pierrick Bouvier wrote: @@ -1061,15 +1061,13 @@ static inline void tlb_set_compare(CPUTLBEntryFull *full, CPUTLBEntry *ent, vaddr address, int flags, MMUAccessType access_type, bool enable)   { -    if (e

Re: [PATCH 19/23] accel/tcg: Always use IntervalTree for code lookups

2024-10-09 Thread Pierrick Bouvier
On 10/9/24 08:08, Richard Henderson wrote: Because translation is special, we don't need the speed of the direct-mapped softmmu tlb. We cache a lookups in DisasContextBase within the translator loop anyway. Drop the addr_code comparator from CPUTLBEntry. Go directly to the IntervalTree for MMU_

[PATCH 19/23] accel/tcg: Always use IntervalTree for code lookups

2024-10-09 Thread Richard Henderson
Because translation is special, we don't need the speed of the direct-mapped softmmu tlb. We cache a lookups in DisasContextBase within the translator loop anyway. Drop the addr_code comparator from CPUTLBEntry. Go directly to the IntervalTree for MMU_INST_FETCH. Derive exec flags from read flags