Re: [PATCH 18/22] riscv/sifive_u: Fix sifive_u_soc_realize() error API violations

2020-06-22 Thread Alistair Francis
On Mon, Jun 22, 2020 at 3:55 AM Markus Armbruster wrote: > > The Error ** argument must be NULL, &error_abort, &error_fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error, it

[PATCH 18/22] riscv/sifive_u: Fix sifive_u_soc_realize() error API violations

2020-06-22 Thread Markus Armbruster
The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. sifive_u_soc_realize(