Re: [PATCH 18/20] keyval: Use GString to accumulate value strings

2021-01-11 Thread Paolo Bonzini
On 11/01/21 14:05, Markus Armbruster wrote: I had to choose between creating a conflict and holding back my series while we figure out what to do with your patch. The dilemma is my own doing; your patch is waiting just for me. I picked the conflict. I can look into rebasing your patch on top o

Re: [PATCH 18/20] keyval: Use GString to accumulate value strings

2021-01-11 Thread Markus Armbruster
Paolo Bonzini writes: > On 11/12/20 18:11, Markus Armbruster wrote: >> QString supports modifying its string, but it's quite limited: you can >> only append. The remaining callers use it for building an initial >> string, never for modifying it later. >> Change keyval_parse_one() to do build the

Re: [PATCH 18/20] keyval: Use GString to accumulate value strings

2020-12-22 Thread Paolo Bonzini
On 11/12/20 18:11, Markus Armbruster wrote: QString supports modifying its string, but it's quite limited: you can only append. The remaining callers use it for building an initial string, never for modifying it later. Change keyval_parse_one() to do build the initial string with GString. This

[PATCH 18/20] keyval: Use GString to accumulate value strings

2020-12-11 Thread Markus Armbruster
QString supports modifying its string, but it's quite limited: you can only append. The remaining callers use it for building an initial string, never for modifying it later. Change keyval_parse_one() to do build the initial string with GString. This is another step towards making QString immutab