Re: [PATCH 17/20] spapr: Remove unused return value in claim path

2019-09-26 Thread David Gibson
On Thu, Sep 26, 2019 at 10:36:02AM +0200, Greg Kurz wrote: > On Wed, 25 Sep 2019 16:45:31 +1000 > David Gibson wrote: > > > spapr_irq_claim() and the hooks it is based on return an integer error code > > as well as taking an Error ** parameter. But none of the callers check the > > integer, so w

Re: [PATCH 17/20] spapr: Remove unused return value in claim path

2019-09-26 Thread Greg Kurz
On Wed, 25 Sep 2019 16:45:31 +1000 David Gibson wrote: > spapr_irq_claim() and the hooks it is based on return an integer error code > as well as taking an Error ** parameter. But none of the callers check the > integer, so we can remove it and just use the richer Error **. > > Signed-off-by: D

Re: [PATCH 17/20] spapr: Remove unused return value in claim path

2019-09-26 Thread Philippe Mathieu-Daudé
On 9/25/19 8:45 AM, David Gibson wrote: > spapr_irq_claim() and the hooks it is based on return an integer error code > as well as taking an Error ** parameter. But none of the callers check the > integer, so we can remove it and just use the richer Error **. > > Signed-off-by: David Gibson > --

Re: [PATCH 17/20] spapr: Remove unused return value in claim path

2019-09-25 Thread Cédric Le Goater
On 25/09/2019 08:45, David Gibson wrote: > spapr_irq_claim() and the hooks it is based on return an integer error code > as well as taking an Error ** parameter. But none of the callers check the > integer, so we can remove it and just use the richer Error **. > > Signed-off-by: David Gibson Re

[PATCH 17/20] spapr: Remove unused return value in claim path

2019-09-25 Thread David Gibson
spapr_irq_claim() and the hooks it is based on return an integer error code as well as taking an Error ** parameter. But none of the callers check the integer, so we can remove it and just use the richer Error **. Signed-off-by: David Gibson --- hw/ppc/spapr_irq.c | 32 +