Re: [PATCH 16/25] qapi: Move context-sensitive checking to the proper place

2019-09-24 Thread Markus Armbruster
Eric Blake writes: > On 9/24/19 8:28 AM, Markus Armbruster wrote: >> When we introduced the QAPISchema intermediate representation (commit >> ac88219a6c7), we took a shortcut: we left check_exprs() & friends >> alone instead of moving semantic checks into the >> QAPISchemaFOO.check(). The .check

Re: [PATCH 16/25] qapi: Move context-sensitive checking to the proper place

2019-09-24 Thread Eric Blake
On 9/24/19 8:28 AM, Markus Armbruster wrote: > When we introduced the QAPISchema intermediate representation (commit > ac88219a6c7), we took a shortcut: we left check_exprs() & friends > alone instead of moving semantic checks into the > QAPISchemaFOO.check(). The .check() assert check_exprs() did

[PATCH 16/25] qapi: Move context-sensitive checking to the proper place

2019-09-24 Thread Markus Armbruster
When we introduced the QAPISchema intermediate representation (commit ac88219a6c7), we took a shortcut: we left check_exprs() & friends alone instead of moving semantic checks into the QAPISchemaFOO.check(). The .check() assert check_exprs() did its job. Time to finish the conversion job. Move e