Re: [PATCH 16/22] hw: Fix error API violation around object_property_set_link()

2020-06-22 Thread Alistair Francis
On Mon, Jun 22, 2020 at 3:53 AM Markus Armbruster wrote: > > The Error ** argument must be NULL, &error_abort, &error_fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error, it

Re: [PATCH 16/22] hw: Fix error API violation around object_property_set_link()

2020-06-22 Thread Auger Eric
Hi Markus, On 6/22/20 12:42 PM, Markus Armbruster wrote: > The Error ** argument must be NULL, &error_abort, &error_fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error, it no

[PATCH 16/22] hw: Fix error API violation around object_property_set_link()

2020-06-22 Thread Markus Armbruster
The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. virtio_gpu_pci_base_r