Re: [PATCH 14/22] plugins: make test/example plugins work on windows

2023-11-08 Thread Paolo Bonzini
On Tue, Nov 7, 2023 at 1:43 PM Greg Manning wrote: > Windows will look for __pfnDliFailureHook2 in the module doing the delay > loading, which in this case is the plugin DLL. Fair enough, this is what was not clear from the Microsoft docs. Paolo

Re: [PATCH 14/22] plugins: make test/example plugins work on windows

2023-11-07 Thread Greg Manning
> > A bit more important: would it make sense to include the hook *in the > > QEMU executable itself*, rather than in the DLL? If it works, it would > > be much preferrable. You still would have to add the .lib file to the > > compilation, but win32_linker.c could simply be placed in os-win32.c >

Re: [PATCH 14/22] plugins: make test/example plugins work on windows

2023-11-07 Thread Greg Manning
From: Paolo Bonzini One important remark below that Greg can answer; the others are nits. > ... > I think this could also use the notification hook and dliNotePreLoadLibrary. That's a little more tidy but it's okay either way. I don't really mind. I had in mind that there might someday be a sin

Re: [PATCH 14/22] plugins: make test/example plugins work on windows

2023-11-07 Thread Paolo Bonzini
One important remark below that Greg can answer; the others are nits. On 11/6/23 19:51, Alex Bennée wrote: diff --git a/contrib/plugins/win32_linker.c b/contrib/plugins/win32_linker.c new file mode 100644 index 00..50797d616e --- /dev/null +++ b/contrib/plugins/win32_linker.c @@ -0,0 +1,

[PATCH 14/22] plugins: make test/example plugins work on windows

2023-11-06 Thread Alex Bennée
From: Greg Manning Generate a qemu_plugin_api.lib delay import lib on windows, for windows qemu plugins to link against. Implement an example dll load fail hook to link up the API functions correctly when a plugin is loaded on windows. Update the build scripts for the test and example plugins t