Re: [PATCH 14/22] Implement msync(2)

2023-08-20 Thread Richard Henderson
On 8/19/23 02:47, Karim Taha wrote: +static inline abi_long do_bsd_msync(abi_long addr, abi_long len, abi_long flags) +{ +if (!access_ok(VERIFY_WRITE, addr, len)) { I think this check is wrong. There's nothing in the kernel that requires writability, or even that the entire range be mapp

Re: [PATCH 14/22] Implement msync(2)

2023-08-19 Thread Warner Losh
On Sat, Aug 19, 2023 at 3:49 AM Karim Taha wrote: > From: Stacey Son > > Co-authored-by: Kyle Evans > > Signed-off-by: Stacey Son > Signed-off-by: Kyle Evans > Signed-off-by: Karim Taha > --- > bsd-user/bsd-mem.h| 11 +++ > bsd-user/freebsd/os-syscall.c | 4 > 2 fi

[PATCH 14/22] Implement msync(2)

2023-08-19 Thread Karim Taha
From: Stacey Son Co-authored-by: Kyle Evans Signed-off-by: Stacey Son Signed-off-by: Kyle Evans Signed-off-by: Karim Taha --- bsd-user/bsd-mem.h| 11 +++ bsd-user/freebsd/os-syscall.c | 4 2 files changed, 15 insertions(+) diff --git a/bsd-user/bsd-mem.h b/bsd-use