Re: [PATCH 14/17] migration/option: Fix missing ERRP_GUARD() for error_prepend()

2024-02-29 Thread Peter Xu
On Thu, Feb 29, 2024 at 10:39:11PM +0800, Zhao Liu wrote: > From: Zhao Liu > > As the comment in qapi/error, passing @errp to error_prepend() requires > ERRP_GUARD(): > > * = Why, when and how to use ERRP_GUARD() = > * > * Without ERRP_GUARD(), use of the @errp parameter is restricted: > ... > *

Re: [PATCH 14/17] migration/option: Fix missing ERRP_GUARD() for error_prepend()

2024-02-29 Thread Fabiano Rosas
Zhao Liu writes: > From: Zhao Liu > > As the comment in qapi/error, passing @errp to error_prepend() requires > ERRP_GUARD(): > > * = Why, when and how to use ERRP_GUARD() = > * > * Without ERRP_GUARD(), use of the @errp parameter is restricted: > ... > * - It should not be passed to error_prepe

[PATCH 14/17] migration/option: Fix missing ERRP_GUARD() for error_prepend()

2024-02-29 Thread Zhao Liu
From: Zhao Liu As the comment in qapi/error, passing @errp to error_prepend() requires ERRP_GUARD(): * = Why, when and how to use ERRP_GUARD() = * * Without ERRP_GUARD(), use of the @errp parameter is restricted: ... * - It should not be passed to error_prepend(), error_vprepend() or * error_a