Re: [PATCH 13/28] qapi: Enforce event naming rules

2021-03-25 Thread John Snow
On 3/25/21 2:22 AM, Markus Armbruster wrote: John Snow writes: On 3/24/21 2:22 AM, Markus Armbruster wrote: John Snow writes: On 3/23/21 5:40 AM, Markus Armbruster wrote: Event names should be ALL_CAPS with words separated by underscore. Enforce this. The only offenders are in tests/. F

Re: [PATCH 13/28] qapi: Enforce event naming rules

2021-03-24 Thread Markus Armbruster
John Snow writes: > On 3/24/21 2:22 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 3/23/21 5:40 AM, Markus Armbruster wrote: Event names should be ALL_CAPS with words separated by underscore. Enforce this. The only offenders are in tests/. Fix them. Existing test

Re: [PATCH 13/28] qapi: Enforce event naming rules

2021-03-24 Thread John Snow
On 3/24/21 2:22 AM, Markus Armbruster wrote: John Snow writes: On 3/23/21 5:40 AM, Markus Armbruster wrote: Event names should be ALL_CAPS with words separated by underscore. Enforce this. The only offenders are in tests/. Fix them. Existing test event-case covers the new error. Signed-off

Re: [PATCH 13/28] qapi: Enforce event naming rules

2021-03-23 Thread Markus Armbruster
John Snow writes: > On 3/23/21 5:40 AM, Markus Armbruster wrote: >> Event names should be ALL_CAPS with words separated by underscore. >> Enforce this. The only offenders are in tests/. Fix them. Existing >> test event-case covers the new error. >> Signed-off-by: Markus Armbruster >> --- >>

Re: [PATCH 13/28] qapi: Enforce event naming rules

2021-03-23 Thread John Snow
On 3/23/21 5:40 AM, Markus Armbruster wrote: Event names should be ALL_CAPS with words separated by underscore. Enforce this. The only offenders are in tests/. Fix them. Existing test event-case covers the new error. Signed-off-by: Markus Armbruster --- tests/unit/test-qmp-event.c

Re: [PATCH 13/28] qapi: Enforce event naming rules

2021-03-23 Thread Eric Blake
On 3/23/21 4:40 AM, Markus Armbruster wrote: > Event names should be ALL_CAPS with words separated by underscore. > Enforce this. The only offenders are in tests/. Fix them. Existing > test event-case covers the new error. > > Signed-off-by: Markus Armbruster > --- Reviewed-by: Eric Blake -

[PATCH 13/28] qapi: Enforce event naming rules

2021-03-23 Thread Markus Armbruster
Event names should be ALL_CAPS with words separated by underscore. Enforce this. The only offenders are in tests/. Fix them. Existing test event-case covers the new error. Signed-off-by: Markus Armbruster --- tests/unit/test-qmp-event.c | 6 +++--- scripts/qapi/expr.py