Re: [PATCH 13/26] hw/intc/arm_gicv3_its: Use FIELD macros for CTEs

2021-12-13 Thread Alex Bennée
Peter Maydell writes: > Use FIELD macros to handle CTEs, rather than ad-hoc mask-and-shift. > > Signed-off-by: Peter Maydell > --- > hw/intc/gicv3_internal.h | 3 ++- > hw/intc/arm_gicv3_its.c | 7 --- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/hw/intc/gicv3_inte

Re: [PATCH 13/26] hw/intc/arm_gicv3_its: Use FIELD macros for CTEs

2021-12-12 Thread Richard Henderson
On 12/11/21 11:11 AM, Peter Maydell wrote: Use FIELD macros to handle CTEs, rather than ad-hoc mask-and-shift. Signed-off-by: Peter Maydell --- hw/intc/gicv3_internal.h | 3 ++- hw/intc/arm_gicv3_its.c | 7 --- 2 files changed, 6 insertions(+), 4 deletions(-) Reviewed-by: Richard Hen

[PATCH 13/26] hw/intc/arm_gicv3_its: Use FIELD macros for CTEs

2021-12-11 Thread Peter Maydell
Use FIELD macros to handle CTEs, rather than ad-hoc mask-and-shift. Signed-off-by: Peter Maydell --- hw/intc/gicv3_internal.h | 3 ++- hw/intc/arm_gicv3_its.c | 7 --- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/intc/gicv3_internal.h b/hw/intc/gicv3_internal.h index 14