Re: [PATCH 13/17] hw/gpio/zaurus.c: Use LOG_GUEST_ERROR for bad guest register accesses

2020-06-30 Thread Alistair Francis
On Sun, Jun 28, 2020 at 7:35 AM Peter Maydell wrote: > > Instead of logging guest accesses to invalid register offsets in this > device using zaurus_printf() (which just prints to stderr), use the > usual qemu_log_mask(LOG_GUEST_ERROR,...). > > Since this was the only use of the zaurus_printf() ma

Re: [PATCH 13/17] hw/gpio/zaurus.c: Use LOG_GUEST_ERROR for bad guest register accesses

2020-06-29 Thread Philippe Mathieu-Daudé
On 6/28/20 4:24 PM, Peter Maydell wrote: > Instead of logging guest accesses to invalid register offsets in this > device using zaurus_printf() (which just prints to stderr), use the > usual qemu_log_mask(LOG_GUEST_ERROR,...). > > Since this was the only use of the zaurus_printf() macro outside >

[PATCH 13/17] hw/gpio/zaurus.c: Use LOG_GUEST_ERROR for bad guest register accesses

2020-06-28 Thread Peter Maydell
Instead of logging guest accesses to invalid register offsets in this device using zaurus_printf() (which just prints to stderr), use the usual qemu_log_mask(LOG_GUEST_ERROR,...). Since this was the only use of the zaurus_printf() macro outside spitz.c, we can move the definition of that macro fro