Re: [PATCH 13/13] hw/ide: Extract bmdma_clear_status()

On 22/04/2023 16:07, Bernhard Beschow wrote: Extract bmdma_clear_status() mirroring bmdma_cmd_writeb(). Signed-off-by: Bernhard Beschow --- include/hw/ide/pci.h | 1 + hw/ide/cmd646.c | 2 +- hw/ide/pci.c | 7 +++ hw/ide/piix.c| 2 +- hw/ide/sii3112.c | 1

Re: [PATCH 13/13] hw/ide: Extract bmdma_clear_status()

Am 23. April 2023 10:40:50 UTC schrieb BALATON Zoltan : >On Sun, 23 Apr 2023, Bernhard Beschow wrote: >> Am 22. April 2023 21:26:00 UTC schrieb BALATON Zoltan : >>> On Sat, 22 Apr 2023, Bernhard Beschow wrote: Extract bmdma_clear_status() mirroring bmdma_cmd_writeb(). >>> >>> Is adding a t

Re: [PATCH 13/13] hw/ide: Extract bmdma_clear_status()

On Sun, 23 Apr 2023, Bernhard Beschow wrote: Am 22. April 2023 21:26:00 UTC schrieb BALATON Zoltan : On Sat, 22 Apr 2023, Bernhard Beschow wrote: Extract bmdma_clear_status() mirroring bmdma_cmd_writeb(). Is adding a trace point useful? This is called from places that already have traces so

Re: [PATCH 13/13] hw/ide: Extract bmdma_clear_status()

Am 22. April 2023 21:26:00 UTC schrieb BALATON Zoltan : >On Sat, 22 Apr 2023, Bernhard Beschow wrote: >> Extract bmdma_clear_status() mirroring bmdma_cmd_writeb(). > >Is adding a trace point useful? This is called from places that already have >traces so I don't think we need another separate t

Re: [PATCH 13/13] hw/ide: Extract bmdma_clear_status()

Am 22. April 2023 22:46:08 UTC schrieb BALATON Zoltan : >On Sat, 22 Apr 2023, Bernhard Beschow wrote: >> Extract bmdma_clear_status() mirroring bmdma_cmd_writeb(). >> >> Signed-off-by: Bernhard Beschow >> --- >> include/hw/ide/pci.h | 1 + >> hw/ide/cmd646.c | 2 +- >> hw/ide/pci.c

Re: [PATCH 13/13] hw/ide: Extract bmdma_clear_status()

On Sat, 22 Apr 2023, Bernhard Beschow wrote: Extract bmdma_clear_status() mirroring bmdma_cmd_writeb(). Signed-off-by: Bernhard Beschow --- include/hw/ide/pci.h | 1 + hw/ide/cmd646.c | 2 +- hw/ide/pci.c | 7 +++ hw/ide/piix.c| 2 +- hw/ide/sii3112.c | 12 +

Re: [PATCH 13/13] hw/ide: Extract bmdma_clear_status()

On Sat, 22 Apr 2023, Bernhard Beschow wrote: Extract bmdma_clear_status() mirroring bmdma_cmd_writeb(). Is adding a trace point useful? This is called from places that already have traces so I don't think we need another separate trace point here. Also the names don't match but maybe rename f

[PATCH 13/13] hw/ide: Extract bmdma_clear_status()

Extract bmdma_clear_status() mirroring bmdma_cmd_writeb(). Signed-off-by: Bernhard Beschow --- include/hw/ide/pci.h | 1 + hw/ide/cmd646.c | 2 +- hw/ide/pci.c | 7 +++ hw/ide/piix.c| 2 +- hw/ide/sii3112.c | 12 +--- hw/ide/via.c | 2 +- hw/ide/