Re: [PATCH 12/36] qdev: Make error_set_from_qdev_prop_error() get Object* argument

2020-10-30 Thread Eduardo Habkost
On Fri, Oct 30, 2020 at 12:00:33PM +0400, Marc-André Lureau wrote: > On Fri, Oct 30, 2020 at 2:16 AM Eduardo Habkost wrote: > > > Make the code more generic and not specific to TYPE_DEVICE. > > > > Signed-off-by: Eduardo Habkost > > > > What about dropping _qdev from the function name too? I h

Re: [PATCH 12/36] qdev: Make error_set_from_qdev_prop_error() get Object* argument

2020-10-30 Thread Marc-André Lureau
On Fri, Oct 30, 2020 at 2:16 AM Eduardo Habkost wrote: > Make the code more generic and not specific to TYPE_DEVICE. > > Signed-off-by: Eduardo Habkost > What about dropping _qdev from the function name too? Also, I am not sure it's a well designed function.. I would rather have 3 different he

[PATCH 12/36] qdev: Make error_set_from_qdev_prop_error() get Object* argument

2020-10-29 Thread Eduardo Habkost
Make the code more generic and not specific to TYPE_DEVICE. Signed-off-by: Eduardo Habkost --- Cc: Paolo Bonzini Cc: "Daniel P. Berrangé" Cc: Eduardo Habkost Cc: Cornelia Huck Cc: Thomas Huth Cc: Richard Henderson Cc: David Hildenbrand Cc: Halil Pasic Cc: Christian Borntraeger Cc: qemu-d