Re: [PATCH 12/15] s390: remove bios_name

2020-10-27 Thread Paolo Bonzini
On 27/10/20 09:38, Christian Borntraeger wrote: >> >> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c >> index e52182f946..a521eba673 100644 >> --- a/hw/s390x/s390-virtio-ccw.c >> +++ b/hw/s390x/s390-virtio-ccw.c >> @@ -258,7 +258,8 @@ static void ccw_init(MachineState *machi

Re: [PATCH 12/15] s390: remove bios_name

2020-10-27 Thread Christian Borntraeger
On 26.10.20 15:30, Paolo Bonzini wrote: > Cc: Thomas Huth > Signed-off-by: Paolo Bonzini > --- > hw/s390x/ipl.c | 8 ++-- > hw/s390x/s390-virtio-ccw.c | 3 ++- > 2 files changed, 4 insertions(+), 7 deletions(-) > > diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c > index 3d2652d7

Re: [PATCH 12/15] s390: remove bios_name

2020-10-27 Thread Cornelia Huck
On Mon, 26 Oct 2020 10:30:25 -0400 Paolo Bonzini wrote: > Cc: Thomas Huth > Signed-off-by: Paolo Bonzini > --- > hw/s390x/ipl.c | 8 ++-- > hw/s390x/s390-virtio-ccw.c | 3 ++- > 2 files changed, 4 insertions(+), 7 deletions(-) Reviewed-by: Cornelia Huck

Re: [PATCH 12/15] s390: remove bios_name

2020-10-26 Thread Thomas Huth
On 26/10/2020 15.30, Paolo Bonzini wrote: > Cc: Thomas Huth > Signed-off-by: Paolo Bonzini > --- > hw/s390x/ipl.c | 8 ++-- > hw/s390x/s390-virtio-ccw.c | 3 ++- > 2 files changed, 4 insertions(+), 7 deletions(-) > > diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c > index 3d2652d75

Re: [PATCH 12/15] s390: remove bios_name

2020-10-26 Thread Alex Bennée
Paolo Bonzini writes: Might be worth mentioning the trixy path from qdev_prop_set_string to end up in ipl->firmware because it's not obvious just from the diff. Anyway: Reviewed-by: Alex Bennée -- Alex Bennée

[PATCH 12/15] s390: remove bios_name

2020-10-26 Thread Paolo Bonzini
Cc: Thomas Huth Signed-off-by: Paolo Bonzini --- hw/s390x/ipl.c | 8 ++-- hw/s390x/s390-virtio-ccw.c | 3 ++- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index 3d2652d75a..61e8c967d3 100644 --- a/hw/s390x/ipl.c +++ b/hw/s390x/ipl