Re: [PATCH 12/14] ppc/pnv: Remove "system-memory" property for he PHB4 PEC model

2021-12-07 Thread Cédric Le Goater
On 12/7/21 11:08, Frederic Barrat wrote: On 02/12/2021 15:42, Cédric Le Goater wrote: This is not useful and will be in the way for support of user created PHB4 devices. Signed-off-by: Cédric Le Goater --- I doubt I see all the implications here, It is good practice to avoid statics in

Re: [PATCH 12/14] ppc/pnv: Remove "system-memory" property for he PHB4 PEC model

2021-12-07 Thread Frederic Barrat
On 02/12/2021 15:42, Cédric Le Goater wrote: This is not useful and will be in the way for support of user created PHB4 devices. Signed-off-by: Cédric Le Goater --- I forgot to mention the typo in the commit title: "he PHB4". Fred hw/pci-host/pnv_phb4_pec.c | 6 +- hw/ppc/pnv

Re: [PATCH 12/14] ppc/pnv: Remove "system-memory" property for he PHB4 PEC model

2021-12-07 Thread Frederic Barrat
On 02/12/2021 15:42, Cédric Le Goater wrote: This is not useful and will be in the way for support of user created PHB4 devices. Signed-off-by: Cédric Le Goater --- I doubt I see all the implications here, but it doesn't look wrong to me, so: Reviewed-by: Frederic Barrat Fred h

Re: [PATCH 12/14] ppc/pnv: Remove "system-memory" property for he PHB4 PEC model

2021-12-02 Thread Daniel Henrique Barboza
On 12/2/21 11:42, Cédric Le Goater wrote: This is not useful and will be in the way for support of user created PHB4 devices. Signed-off-by: Cédric Le Goater --- Reviewed-by: Daniel Henrique Barboza hw/pci-host/pnv_phb4_pec.c | 6 +- hw/ppc/pnv.c | 2 -- 2 files ch

[PATCH 12/14] ppc/pnv: Remove "system-memory" property for he PHB4 PEC model

2021-12-02 Thread Cédric Le Goater
This is not useful and will be in the way for support of user created PHB4 devices. Signed-off-by: Cédric Le Goater --- hw/pci-host/pnv_phb4_pec.c | 6 +- hw/ppc/pnv.c | 2 -- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/pci-host/pnv_phb4_pec.c b/hw/pci-host