Re: [PATCH 12/14] iotests: remove qemu_img_pipe_and_status()

2022-03-17 Thread John Snow
On Thu, Mar 17, 2022 at 12:04 PM Hanna Reitz wrote: > > On 17.03.22 16:58, John Snow wrote: > > On Thu, Mar 17, 2022 at 11:28 AM Hanna Reitz wrote: > >> On 09.03.22 04:54, John Snow wrote: > >>> With the exceptional 'create' calls removed in the prior commit, change > >>> qemu_img_log() and img_i

Re: [PATCH 12/14] iotests: remove qemu_img_pipe_and_status()

2022-03-17 Thread Hanna Reitz
On 17.03.22 16:58, John Snow wrote: On Thu, Mar 17, 2022 at 11:28 AM Hanna Reitz wrote: On 09.03.22 04:54, John Snow wrote: With the exceptional 'create' calls removed in the prior commit, change qemu_img_log() and img_info_log() to call qemu_img() directly instead. In keeping with the spirit

Re: [PATCH 12/14] iotests: remove qemu_img_pipe_and_status()

2022-03-17 Thread John Snow
On Thu, Mar 17, 2022 at 11:28 AM Hanna Reitz wrote: > > On 09.03.22 04:54, John Snow wrote: > > With the exceptional 'create' calls removed in the prior commit, change > > qemu_img_log() and img_info_log() to call qemu_img() directly > > instead. > > > > In keeping with the spirit of diff-based te

Re: [PATCH 12/14] iotests: remove qemu_img_pipe_and_status()

2022-03-17 Thread Hanna Reitz
On 09.03.22 04:54, John Snow wrote: With the exceptional 'create' calls removed in the prior commit, change qemu_img_log() and img_info_log() to call qemu_img() directly instead. In keeping with the spirit of diff-based tests, allow these calls to qemu_img() to return an unchecked non-zero statu

[PATCH 12/14] iotests: remove qemu_img_pipe_and_status()

2022-03-08 Thread John Snow
With the exceptional 'create' calls removed in the prior commit, change qemu_img_log() and img_info_log() to call qemu_img() directly instead. In keeping with the spirit of diff-based tests, allow these calls to qemu_img() to return an unchecked non-zero status code -- because any error we'd see f