Re: [PATCH 12/13] hw/ide/sii3112: Reuse PCIIDEState::bmdma_ops

2023-04-26 Thread Bernhard Beschow
Am 26. April 2023 11:44:29 UTC schrieb Mark Cave-Ayland : >On 22/04/2023 16:07, Bernhard Beschow wrote: > >> Allows to unexport bmdma_addr_ioport_ops and models TYPE_SII3112_PCI as a >> standard-compliant PCI IDE device. > >Nice! I think it's worth adding a brief mention that you've added BMDMA

Re: [PATCH 12/13] hw/ide/sii3112: Reuse PCIIDEState::bmdma_ops

2023-04-26 Thread Mark Cave-Ayland
On 22/04/2023 16:07, Bernhard Beschow wrote: Allows to unexport bmdma_addr_ioport_ops and models TYPE_SII3112_PCI as a standard-compliant PCI IDE device. Nice! I think it's worth adding a brief mention that you've added BMDMA trace-events, but otherwise looks sensible to me. Signed-off-by:

[PATCH 12/13] hw/ide/sii3112: Reuse PCIIDEState::bmdma_ops

2023-04-22 Thread Bernhard Beschow
Allows to unexport bmdma_addr_ioport_ops and models TYPE_SII3112_PCI as a standard-compliant PCI IDE device. Signed-off-by: Bernhard Beschow --- include/hw/ide/pci.h | 1 - hw/ide/pci.c | 2 +- hw/ide/sii3112.c | 94 ++-- hw/ide/trace-events