Re: [PATCH 11/25] block/nvme: Make nvme_identify() return boolean indicating error

2020-10-28 Thread Stefan Hajnoczi
On Wed, Oct 28, 2020 at 12:03:00PM +0100, Auger Eric wrote: > On 10/27/20 2:55 PM, Philippe Mathieu-Daudé wrote: > > Just for consistency, following the example documented since > > commit e3fe3988d7 ("error: Document Error API usage rules"), > > return a boolean value indicating an error is set or

Re: [PATCH 11/25] block/nvme: Make nvme_identify() return boolean indicating error

2020-10-28 Thread Auger Eric
Hi, On 10/27/20 2:55 PM, Philippe Mathieu-Daudé wrote: > Just for consistency, following the example documented since > commit e3fe3988d7 ("error: Document Error API usage rules"), > return a boolean value indicating an error is set or not. Then I think the returned value should be used by the cal

[PATCH 11/25] block/nvme: Make nvme_identify() return boolean indicating error

2020-10-27 Thread Philippe Mathieu-Daudé
Just for consistency, following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), return a boolean value indicating an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-)