Re: [PATCH 11/18] crypto: rename des-rfb cipher to just des

2021-07-09 Thread Daniel P . Berrangé
On Thu, Jul 08, 2021 at 04:41:28PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Wed, Jul 07, 2021 at 02:47:15PM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > Currently the crypto layer exposes support for a 'des-rfb' > >> > algorithm which

Re: [PATCH 11/18] crypto: rename des-rfb cipher to just des

2021-07-08 Thread Eric Blake
On Tue, Jul 06, 2021 at 10:59:17AM +0100, Daniel P. Berrangé wrote: > Currently the crypto layer exposes support for a 'des-rfb' > algorithm which is just normal single-DES, with the bits > in each key byte reversed. This special key munging is > required by the RFB protocol password authentication

Re: [PATCH 11/18] crypto: rename des-rfb cipher to just des

2021-07-08 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Jul 07, 2021 at 02:47:15PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > Currently the crypto layer exposes support for a 'des-rfb' >> > algorithm which is just normal single-DES, with the bits >> > in each key byte reversed. This spe

Re: [PATCH 11/18] crypto: rename des-rfb cipher to just des

2021-07-07 Thread Daniel P . Berrangé
On Wed, Jul 07, 2021 at 02:47:15PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > Currently the crypto layer exposes support for a 'des-rfb' > > algorithm which is just normal single-DES, with the bits > > in each key byte reversed. This special key munging is > > required by

Re: [PATCH 11/18] crypto: rename des-rfb cipher to just des

2021-07-07 Thread Markus Armbruster
Daniel P. Berrangé writes: > Currently the crypto layer exposes support for a 'des-rfb' > algorithm which is just normal single-DES, with the bits > in each key byte reversed. This special key munging is > required by the RFB protocol password authentication > mechanism. > > Since the crypto laye

[PATCH 11/18] crypto: rename des-rfb cipher to just des

2021-07-06 Thread Daniel P . Berrangé
Currently the crypto layer exposes support for a 'des-rfb' algorithm which is just normal single-DES, with the bits in each key byte reversed. This special key munging is required by the RFB protocol password authentication mechanism. Since the crypto layer is generic shared code, it makes more se