Re: [PATCH 11/14] target/arm: Implement the SETG* instructions

2023-09-11 Thread Richard Henderson
On 9/11/23 07:17, Peter Maydell wrote: I think it would be a little better if set_tags was visible to the compiler, via inlining, so that all of the conditions can be folded away. Do you mean having a separate triplet of helper functions for setg, which then call an inline function shared with

Re: [PATCH 11/14] target/arm: Implement the SETG* instructions

2023-09-11 Thread Peter Maydell
On Sat, 9 Sept 2023 at 17:38, Richard Henderson wrote: > > On 9/7/23 09:03, Peter Maydell wrote: > > The FEAT_MOPS SETG* instructions are very similar to the SET* > > instructions, but as well as setting memory contents they also > > set the MTE tags. They are architecturally required to operate >

Re: [PATCH 11/14] target/arm: Implement the SETG* instructions

2023-09-09 Thread Richard Henderson
On 9/7/23 09:03, Peter Maydell wrote: The FEAT_MOPS SETG* instructions are very similar to the SET* instructions, but as well as setting memory contents they also set the MTE tags. They are architecturally required to operate on tag-granule aligned regions only. Signed-off-by: Peter Maydell ---

[PATCH 11/14] target/arm: Implement the SETG* instructions

2023-09-07 Thread Peter Maydell
The FEAT_MOPS SETG* instructions are very similar to the SET* instructions, but as well as setting memory contents they also set the MTE tags. They are architecturally required to operate on tag-granule aligned regions only. Signed-off-by: Peter Maydell --- target/arm/internals.h | 10 ++