Re: [PATCH 11/12] migration/colo: Improve an x-colo-lost-heartbeat error message

2023-02-07 Thread Markus Armbruster
Juan Quintela writes: > Markus Armbruster wrote: >> The QERR_ macros are leftovers from the days of "rich" error objects. >> We've been trying to reduce their remaining use. >> >> Get rid of a use of QERR_FEATURE_DISABLED, and improve the somewhat >> imprecise error message >> >> (qemu) x_co

Re: [PATCH 11/12] migration/colo: Improve an x-colo-lost-heartbeat error message

2023-02-07 Thread Juan Quintela
Markus Armbruster wrote: > The QERR_ macros are leftovers from the days of "rich" error objects. > We've been trying to reduce their remaining use. > > Get rid of a use of QERR_FEATURE_DISABLED, and improve the somewhat > imprecise error message > > (qemu) x_colo_lost_heartbeat > Error: Th

[PATCH 11/12] migration/colo: Improve an x-colo-lost-heartbeat error message

2023-02-06 Thread Markus Armbruster
The QERR_ macros are leftovers from the days of "rich" error objects. We've been trying to reduce their remaining use. Get rid of a use of QERR_FEATURE_DISABLED, and improve the somewhat imprecise error message (qemu) x_colo_lost_heartbeat Error: The feature 'colo' is not enabled to