Re: [PATCH 10/46] qemu-option: Check return value instead of @err where convenient

2020-07-02 Thread Vladimir Sementsov-Ogievskiy
01.07.2020 11:02, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 24.06.2020 19:43, Markus Armbruster wrote: Convert uses like opts = qemu_opts_create(..., &err); if (err) { ... } to opts = qemu_opts_create(..., &err); if (!opts) {

Re: [PATCH 10/46] qemu-option: Check return value instead of @err where convenient

2020-07-01 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 24.06.2020 19:43, Markus Armbruster wrote: >> Convert uses like >> >> opts = qemu_opts_create(..., &err); >> if (err) { >> ... >> } >> >> to >> >> opts = qemu_opts_create(..., &err); >> if (!opts) { >> ... >> }

Re: [PATCH 10/46] qemu-option: Check return value instead of @err where convenient

2020-06-29 Thread Vladimir Sementsov-Ogievskiy
24.06.2020 19:43, Markus Armbruster wrote: Convert uses like opts = qemu_opts_create(..., &err); if (err) { ... } to opts = qemu_opts_create(..., &err); if (!opts) { ... } Eliminate error_propagate() that are now unnecessary. Delete @err that a

Re: [PATCH 10/46] qemu-option: Check return value instead of @err where convenient

2020-06-24 Thread Eric Blake
On 6/24/20 11:43 AM, Markus Armbruster wrote: Convert uses like opts = qemu_opts_create(..., &err); if (err) { ... } to opts = qemu_opts_create(..., &err); if (!opts) { ... } Eliminate error_propagate() that are now unnecessary. Delete @err tha

[PATCH 10/46] qemu-option: Check return value instead of @err where convenient

2020-06-24 Thread Markus Armbruster
Convert uses like opts = qemu_opts_create(..., &err); if (err) { ... } to opts = qemu_opts_create(..., &err); if (!opts) { ... } Eliminate error_propagate() that are now unnecessary. Delete @err that are now unused. Signed-off-by: Markus Armbruster ---