Re: [PATCH 10/21] hw/core: Fix latent fit_load_fdt() error handling bug

2020-01-13 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 06.12.2019 13:53, Vladimir Sementsov-Ogievskiy wrote: >> 06.12.2019 10:46, Markus Armbruster wrote: >>> Vladimir Sementsov-Ogievskiy writes: [...] So much attention to that function :) I'd also propose the following: [...] >>> >>> Looks like

Re: [PATCH 10/21] hw/core: Fix latent fit_load_fdt() error handling bug

2020-01-10 Thread Vladimir Sementsov-Ogievskiy
06.12.2019 13:53, Vladimir Sementsov-Ogievskiy wrote: > 06.12.2019 10:46, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 30.11.2019 22:42, Markus Armbruster wrote: fit_load_fdt() recovers from fit_image_addr() failing with ENOENT. Except it doesn't when its @errp

Re: [PATCH 10/21] hw/core: Fix latent fit_load_fdt() error handling bug

2019-12-06 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 30.11.2019 22:42, Markus Armbruster wrote: >> fit_load_fdt() recovers from fit_image_addr() failing with ENOENT. >> Except it doesn't when its @errp argument is &error_fatal or >> &error_abort, because it blindly passes @errp to fit_image_addr(). >> Messed u

Re: [PATCH 10/21] hw/core: Fix latent fit_load_fdt() error handling bug

2019-12-06 Thread Vladimir Sementsov-Ogievskiy
06.12.2019 10:46, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> 30.11.2019 22:42, Markus Armbruster wrote: >>> fit_load_fdt() recovers from fit_image_addr() failing with ENOENT. >>> Except it doesn't when its @errp argument is &error_fatal or >>> &error_abort, because it bl

Re: [PATCH 10/21] hw/core: Fix latent fit_load_fdt() error handling bug

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
30.11.2019 22:42, Markus Armbruster wrote: > fit_load_fdt() recovers from fit_image_addr() failing with ENOENT. > Except it doesn't when its @errp argument is &error_fatal or > &error_abort, because it blindly passes @errp to fit_image_addr(). > Messed up in commit 3eb99edb48 "loader-fit: Wean off

[PATCH 10/21] hw/core: Fix latent fit_load_fdt() error handling bug

2019-11-30 Thread Markus Armbruster
fit_load_fdt() recovers from fit_image_addr() failing with ENOENT. Except it doesn't when its @errp argument is &error_fatal or &error_abort, because it blindly passes @errp to fit_image_addr(). Messed up in commit 3eb99edb48 "loader-fit: Wean off error_printf()". The bug can't bite as no caller a