Re: [PATCH 10/14] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface

2020-09-17 Thread Vladimir Sementsov-Ogievskiy
17.09.2020 19:35, Alberto Garcia wrote: On Wed 09 Sep 2020 08:59:26 PM CEST, Vladimir Sementsov-Ogievskiy wrote: -/* qcow2_load_dirty_bitmaps() - * Return value is a hint for caller: true means that the Qcow2 header was - * updated. (false doesn't mean that the header should be updated by the

Re: [PATCH 10/14] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface

2020-09-17 Thread Alberto Garcia
On Wed 09 Sep 2020 08:59:26 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > -/* qcow2_load_dirty_bitmaps() > - * Return value is a hint for caller: true means that the Qcow2 header was > - * updated. (false doesn't mean that the header should be updated by the > - * caller, it just means that upda

[PATCH 10/14] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface

2020-09-09 Thread Vladimir Sementsov-Ogievskiy
It's recommended for bool functions with errp to return true on success and false on failure. Non-standard interfaces don't help to understand the code. The change is also needed to reduce error propagation. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h| 3 ++- block/qco