Re: [PATCH 10/13] hw/ide/piix: Reuse PCIIDEState::{cmd,data}_ops

2023-05-19 Thread Bernhard Beschow
Am 18. Mai 2023 14:53:26 UTC schrieb Mark Cave-Ayland : >On 13/05/2023 13:21, Bernhard Beschow wrote: > >> Am 3. Mai 2023 19:52:41 UTC schrieb Mark Cave-Ayland >> : >>> On 27/04/2023 19:15, Bernhard Beschow wrote: >>> Am 27. April 2023 10:52:17 UTC schrieb Mark Cave-Ayland : >

Re: [PATCH 10/13] hw/ide/piix: Reuse PCIIDEState::{cmd,data}_ops

2023-05-18 Thread Mark Cave-Ayland
On 13/05/2023 13:21, Bernhard Beschow wrote: Am 3. Mai 2023 19:52:41 UTC schrieb Mark Cave-Ayland : On 27/04/2023 19:15, Bernhard Beschow wrote: Am 27. April 2023 10:52:17 UTC schrieb Mark Cave-Ayland : On 26/04/2023 21:14, Bernhard Beschow wrote: Am 26. April 2023 18:18:35 UTC schrieb B

Re: [PATCH 10/13] hw/ide/piix: Reuse PCIIDEState::{cmd,data}_ops

2023-05-13 Thread Bernhard Beschow
Am 3. Mai 2023 19:52:41 UTC schrieb Mark Cave-Ayland : >On 27/04/2023 19:15, Bernhard Beschow wrote: > >> Am 27. April 2023 10:52:17 UTC schrieb Mark Cave-Ayland >> : >>> On 26/04/2023 21:14, Bernhard Beschow wrote: >>> Am 26. April 2023 18:18:35 UTC schrieb Bernhard Beschow :

Re: [PATCH 10/13] hw/ide/piix: Reuse PCIIDEState::{cmd,data}_ops

2023-05-03 Thread Mark Cave-Ayland
On 27/04/2023 19:15, Bernhard Beschow wrote: Am 27. April 2023 10:52:17 UTC schrieb Mark Cave-Ayland : On 26/04/2023 21:14, Bernhard Beschow wrote: Am 26. April 2023 18:18:35 UTC schrieb Bernhard Beschow : Am 26. April 2023 11:37:48 UTC schrieb Mark Cave-Ayland : On 22/04/2023 16:07, Be

Re: [PATCH 10/13] hw/ide/piix: Reuse PCIIDEState::{cmd,data}_ops

2023-04-28 Thread BALATON Zoltan
On Fri, 28 Apr 2023, Bernhard Beschow wrote: Am 27. April 2023 18:15:24 UTC schrieb Bernhard Beschow : Am 27. April 2023 10:52:17 UTC schrieb Mark Cave-Ayland : On 26/04/2023 21:14, Bernhard Beschow wrote: Am 26. April 2023 18:18:35 UTC schrieb Bernhard Beschow : Am 26. April 2023 11:37:48 U

Re: [PATCH 10/13] hw/ide/piix: Reuse PCIIDEState::{cmd,data}_ops

2023-04-28 Thread Bernhard Beschow
Am 27. April 2023 18:15:24 UTC schrieb Bernhard Beschow : > > >Am 27. April 2023 10:52:17 UTC schrieb Mark Cave-Ayland >: >>On 26/04/2023 21:14, Bernhard Beschow wrote: >> >>> Am 26. April 2023 18:18:35 UTC schrieb Bernhard Beschow : Am 26. April 2023 11:37:48 UTC schrieb Mark

Re: [PATCH 10/13] hw/ide/piix: Reuse PCIIDEState::{cmd,data}_ops

2023-04-27 Thread Bernhard Beschow
Am 27. April 2023 10:52:17 UTC schrieb Mark Cave-Ayland : >On 26/04/2023 21:14, Bernhard Beschow wrote: > >> Am 26. April 2023 18:18:35 UTC schrieb Bernhard Beschow : >>> >>> >>> Am 26. April 2023 11:37:48 UTC schrieb Mark Cave-Ayland >>> : On 22/04/2023 16:07, Bernhard Beschow wrote: >

Re: [PATCH 10/13] hw/ide/piix: Reuse PCIIDEState::{cmd,data}_ops

2023-04-27 Thread Mark Cave-Ayland
On 26/04/2023 21:14, Bernhard Beschow wrote: Am 26. April 2023 18:18:35 UTC schrieb Bernhard Beschow : Am 26. April 2023 11:37:48 UTC schrieb Mark Cave-Ayland : On 22/04/2023 16:07, Bernhard Beschow wrote: Now that PCIIDEState::{cmd,data}_ops are initialized in the base class constructor

Re: [PATCH 10/13] hw/ide/piix: Reuse PCIIDEState::{cmd,data}_ops

2023-04-26 Thread Bernhard Beschow
Am 26. April 2023 18:18:35 UTC schrieb Bernhard Beschow : > > >Am 26. April 2023 11:37:48 UTC schrieb Mark Cave-Ayland >: >>On 22/04/2023 16:07, Bernhard Beschow wrote: >> >>> Now that PCIIDEState::{cmd,data}_ops are initialized in the base class >>> constructor there is an opportunity for PIIX

Re: [PATCH 10/13] hw/ide/piix: Reuse PCIIDEState::{cmd,data}_ops

2023-04-26 Thread Bernhard Beschow
Am 26. April 2023 11:37:48 UTC schrieb Mark Cave-Ayland : >On 22/04/2023 16:07, Bernhard Beschow wrote: > >> Now that PCIIDEState::{cmd,data}_ops are initialized in the base class >> constructor there is an opportunity for PIIX to reuse these attributes. This >> resolves usage of ide_init_iopor

Re: [PATCH 10/13] hw/ide/piix: Reuse PCIIDEState::{cmd,data}_ops

2023-04-26 Thread Mark Cave-Ayland
On 22/04/2023 16:07, Bernhard Beschow wrote: Now that PCIIDEState::{cmd,data}_ops are initialized in the base class constructor there is an opportunity for PIIX to reuse these attributes. This resolves usage of ide_init_ioport() which would fall back internally to using the isabus global due to

[PATCH 10/13] hw/ide/piix: Reuse PCIIDEState::{cmd,data}_ops

2023-04-22 Thread Bernhard Beschow
Now that PCIIDEState::{cmd,data}_ops are initialized in the base class constructor there is an opportunity for PIIX to reuse these attributes. This resolves usage of ide_init_ioport() which would fall back internally to using the isabus global due to NULL being passed as ISADevice by PIIX. Signed-