Re: [PATCH 1/7] target/i386: disable PerfMonV2 when PERFCORE unavailable

2024-11-06 Thread Zhao Liu
> Thank you very much for the suggestion. > > Yes, this works. The PERFCORE is a prerequisite of PERFMON_V2 (according to > Linux kernel source code). > > 1403 static int __init amd_core_pmu_init(void) > 1404 { > 1405 union cpuid_0x8022_ebx ebx; > 1406 u64 even_ctr_mask = 0ULL

Re: [PATCH 1/7] target/i386: disable PerfMonV2 when PERFCORE unavailable

2024-11-06 Thread dongli . zhang
Hi Zhao, > > You can define dependency like this: > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index 3baa95481fbc..99c69ec9f369 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -1803,6 +1803,10 @@ static FeatureDep feature_dependencies[] = { > .from = { FEAT_

Re: [PATCH 1/7] target/i386: disable PerfMonV2 when PERFCORE unavailable

2024-11-05 Thread Zhao Liu
Hi Dongli, On Mon, Nov 04, 2024 at 01:40:16AM -0800, Dongli Zhang wrote: > Date: Mon, 4 Nov 2024 01:40:16 -0800 > From: Dongli Zhang > Subject: [PATCH 1/7] target/i386: disable PerfMonV2 when PERFCORE > unavailable > X-Mailer: git-send-email 2.43.5 > > When the PERFCORE i

[PATCH 1/7] target/i386: disable PerfMonV2 when PERFCORE unavailable

2024-11-04 Thread Dongli Zhang
When the PERFCORE is disabled with "-cpu host,-perfctr-core", it is reflected in in guest dmesg. [0.285136] Performance Events: AMD PMU driver. However, the guest cpuid indicates the PerfMonV2 is still available. CPU: Extended Performance Monitoring and Debugging (0x8022): AMD p