Re: [PATCH 1/7] target/arm: v8.3 PAC ID_AA64ISAR[12] feature-detection

2023-02-21 Thread Aaron Lindsay
On Feb 13 16:01, Peter Maydell wrote: > On Thu, 2 Feb 2023 at 21:13, Aaron Lindsay > wrote: > > +static inline bool isar_feature_aa64_pauth_epac(const ARMISARegisters *id) > > +{ > > +return isar_feature_pauth_get_features(id) == 0b0010; > > This should ideally be ">= 0b0010", but it depends

Re: [PATCH 1/7] target/arm: v8.3 PAC ID_AA64ISAR[12] feature-detection

2023-02-13 Thread Peter Maydell
On Thu, 2 Feb 2023 at 21:13, Aaron Lindsay wrote: > > Signed-off-by: Aaron Lindsay > diff --git a/target/arm/pauth_helper.c b/target/arm/pauth_helper.c > index d0483bf051..a0c9bea06b 100644 > --- a/target/arm/pauth_helper.c > +++ b/target/arm/pauth_helper.c > @@ -282,8 +282,8 @@ static uint64_t

Re: [PATCH 1/7] target/arm: v8.3 PAC ID_AA64ISAR[12] feature-detection

2023-02-13 Thread Peter Maydell
On Thu, 2 Feb 2023 at 21:13, Aaron Lindsay wrote: > > Signed-off-by: Aaron Lindsay > --- > target/arm/cpu.h | 57 --- > target/arm/helper.c | 4 +-- > target/arm/pauth_helper.c | 4 +-- > 3 files changed, 58 insertions(+), 7 deletions(-) > > d

[PATCH 1/7] target/arm: v8.3 PAC ID_AA64ISAR[12] feature-detection

2023-02-02 Thread Aaron Lindsay
Signed-off-by: Aaron Lindsay --- target/arm/cpu.h | 57 --- target/arm/helper.c | 4 +-- target/arm/pauth_helper.c | 4 +-- 3 files changed, 58 insertions(+), 7 deletions(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 8cf70693be..9b