Re: [PATCH 1/6] tests/qemu-iotests: Improve the check for GNU sed

2022-02-15 Thread Thomas Huth
On 15/02/2022 14.51, Daniel P. Berrangé wrote: On Tue, Feb 15, 2022 at 02:28:24PM +0100, Thomas Huth wrote: On 11/02/2022 17.48, Thomas Huth wrote: On 11/02/2022 17.14, Eric Blake wrote: On Tue, Feb 08, 2022 at 03:52:19PM +0100, Thomas Huth wrote: The current code with $SED has been introduce

Re: [PATCH 1/6] tests/qemu-iotests: Improve the check for GNU sed

2022-02-15 Thread Daniel P . Berrangé
On Tue, Feb 15, 2022 at 02:28:24PM +0100, Thomas Huth wrote: > On 11/02/2022 17.48, Thomas Huth wrote: > > On 11/02/2022 17.14, Eric Blake wrote: > > > On Tue, Feb 08, 2022 at 03:52:19PM +0100, Thomas Huth wrote: > > > > > > The current code with $SED has been introduced almost three years > > > >

Re: [PATCH 1/6] tests/qemu-iotests: Improve the check for GNU sed

2022-02-15 Thread Thomas Huth
On 11/02/2022 17.48, Thomas Huth wrote: On 11/02/2022 17.14, Eric Blake wrote: On Tue, Feb 08, 2022 at 03:52:19PM +0100, Thomas Huth wrote: The current code with $SED has been introduced almost three years ago already...    Can’t we just do `alias sed=gsed`? Maybe ... but let's ask Philippe

Re: [PATCH 1/6] tests/qemu-iotests: Improve the check for GNU sed

2022-02-11 Thread Thomas Huth
On 11/02/2022 17.14, Eric Blake wrote: On Tue, Feb 08, 2022 at 03:52:19PM +0100, Thomas Huth wrote: The current code with $SED has been introduced almost three years ago already...   Can’t we just do `alias sed=gsed`? Maybe ... but let's ask Philippe and Kevin first, who Signed-off commit b

Re: [PATCH 1/6] tests/qemu-iotests: Improve the check for GNU sed

2022-02-11 Thread Eric Blake
On Tue, Feb 08, 2022 at 03:52:19PM +0100, Thomas Huth wrote: > > > The current code with $SED has been introduced almost three years > > > ago already... > > > > > > >   Can’t we just do `alias sed=gsed`? > > > > > > Maybe ... but let's ask Philippe and Kevin first, who Signed-off > > > commit bd

Re: [PATCH 1/6] tests/qemu-iotests: Improve the check for GNU sed

2022-02-08 Thread Thomas Huth
On 08/02/2022 14.11, Philippe Mathieu-Daudé wrote: On 8/2/22 13:38, Thomas Huth wrote: On 08/02/2022 13.28, Hanna Reitz wrote: On 08.02.22 13:13, Thomas Huth wrote: On 08/02/2022 12.46, Hanna Reitz wrote: On 08.02.22 11:13, Thomas Huth wrote: Instead of failing the iotests if GNU sed is not

Re: [PATCH 1/6] tests/qemu-iotests: Improve the check for GNU sed

2022-02-08 Thread Hanna Reitz
On 08.02.22 13:13, Thomas Huth wrote: On 08/02/2022 12.46, Hanna Reitz wrote: On 08.02.22 11:13, Thomas Huth wrote: Instead of failing the iotests if GNU sed is not available (or skipping them completely in the check-block.sh script), it would be better to simply skip the bash-based tests, so t

Re: [PATCH 1/6] tests/qemu-iotests: Improve the check for GNU sed

2022-02-08 Thread Thomas Huth
On 08/02/2022 12.46, Hanna Reitz wrote: On 08.02.22 11:13, Thomas Huth wrote: Instead of failing the iotests if GNU sed is not available (or skipping them completely in the check-block.sh script), it would be better to simply skip the bash-based tests, so that the python-based tests could still

Re: [PATCH 1/6] tests/qemu-iotests: Improve the check for GNU sed

2022-02-08 Thread Thomas Huth
On 08/02/2022 13.28, Hanna Reitz wrote: On 08.02.22 13:13, Thomas Huth wrote: On 08/02/2022 12.46, Hanna Reitz wrote: On 08.02.22 11:13, Thomas Huth wrote: Instead of failing the iotests if GNU sed is not available (or skipping them completely in the check-block.sh script), it would be better

Re: [PATCH 1/6] tests/qemu-iotests: Improve the check for GNU sed

2022-02-08 Thread Philippe Mathieu-Daudé via
On 8/2/22 13:38, Thomas Huth wrote: On 08/02/2022 13.28, Hanna Reitz wrote: On 08.02.22 13:13, Thomas Huth wrote: On 08/02/2022 12.46, Hanna Reitz wrote: On 08.02.22 11:13, Thomas Huth wrote: Instead of failing the iotests if GNU sed is not available (or skipping them completely in the check

Re: [PATCH 1/6] tests/qemu-iotests: Improve the check for GNU sed

2022-02-08 Thread Hanna Reitz
On 08.02.22 11:13, Thomas Huth wrote: Instead of failing the iotests if GNU sed is not available (or skipping them completely in the check-block.sh script), it would be better to simply skip the bash-based tests, so that the python-based tests could still be run. Thus add the check for BusyBox se

[PATCH 1/6] tests/qemu-iotests: Improve the check for GNU sed

2022-02-08 Thread Thomas Huth
Instead of failing the iotests if GNU sed is not available (or skipping them completely in the check-block.sh script), it would be better to simply skip the bash-based tests, so that the python-based tests could still be run. Thus add the check for BusyBox sed to common.rc and mark the tests as "no