Re: [PATCH 1/6] Revert "linux-user: Make sure initial brk(0) is page-aligned"

2023-07-18 Thread Helge Deller
On 7/18/23 15:53, Andreas Schwab wrote: On Jul 17 2023, Helge Deller wrote: This reverts commit d28b3c90cfad1a7e211ae2bce36ecb9071086129. It just hides the real bug, and even the Linux kernel may return page-unaligned addresses. The initial brk is always page aligned, see binfmt_elf.c:set_br

Re: [PATCH 1/6] Revert "linux-user: Make sure initial brk(0) is page-aligned"

2023-07-18 Thread Andreas Schwab
On Jul 17 2023, Helge Deller wrote: > This reverts commit d28b3c90cfad1a7e211ae2bce36ecb9071086129. > > It just hides the real bug, and even the Linux kernel may > return page-unaligned addresses. The initial brk is always page aligned, see binfmt_elf.c:set_brk and the various arch_randomize_brk

[PATCH 1/6] Revert "linux-user: Make sure initial brk(0) is page-aligned"

2023-07-17 Thread Helge Deller
This reverts commit d28b3c90cfad1a7e211ae2bce36ecb9071086129. It just hides the real bug, and even the Linux kernel may return page-unaligned addresses. Signed-off-by: Helge Deller Tested-by: Markus F.X.J. Oberhumer --- linux-user/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)