Re: [PATCH 1/6] Python: close the log file kept by QEMUMachine before reading it

2021-02-17 Thread Wainer dos Santos Moschetta
On 2/15/21 11:34 PM, Cleber Rosa wrote: On Mon, Feb 15, 2021 at 03:30:16PM -0300, Wainer dos Santos Moschetta wrote: Hi, On 2/11/21 7:01 PM, Cleber Rosa wrote: Closing a file that is open for writing, and then reading from it sounds like a better idea than the opposite, given that the conten

Re: [PATCH 1/6] Python: close the log file kept by QEMUMachine before reading it

2021-02-15 Thread Cleber Rosa
On Mon, Feb 15, 2021 at 03:30:16PM -0300, Wainer dos Santos Moschetta wrote: > Hi, > > On 2/11/21 7:01 PM, Cleber Rosa wrote: > > Closing a file that is open for writing, and then reading from it > > sounds like a better idea than the opposite, given that the content > > will be flushed. > > > >

Re: [PATCH 1/6] Python: close the log file kept by QEMUMachine before reading it

2021-02-15 Thread Cleber Rosa
On Mon, Feb 15, 2021 at 05:04:24PM -0500, John Snow wrote: > On 2/11/21 5:01 PM, Cleber Rosa wrote: > > Closing a file that is open for writing, and then reading from it > > sounds like a better idea than the opposite, given that the content > > will be flushed. > > > > Reference: https://docs.pyt

Re: [PATCH 1/6] Python: close the log file kept by QEMUMachine before reading it

2021-02-15 Thread Eric Blake
On 2/15/21 4:04 PM, John Snow wrote: > On 2/11/21 5:01 PM, Cleber Rosa wrote: >> Closing a file that is open for writing, and then reading from it >> sounds like a better idea than the opposite, given that the content >> will be flushed. >> >> Reference: https://docs.python.org/3/library/io.html#io

Re: [PATCH 1/6] Python: close the log file kept by QEMUMachine before reading it

2021-02-15 Thread John Snow
On 2/11/21 5:01 PM, Cleber Rosa wrote: Closing a file that is open for writing, and then reading from it sounds like a better idea than the opposite, given that the content will be flushed. Reference: https://docs.python.org/3/library/io.html#io.IOBase.close Signed-off-by: Cleber Rosa --- pyt

Re: [PATCH 1/6] Python: close the log file kept by QEMUMachine before reading it

2021-02-15 Thread Wainer dos Santos Moschetta
Hi, On 2/11/21 7:01 PM, Cleber Rosa wrote: Closing a file that is open for writing, and then reading from it sounds like a better idea than the opposite, given that the content will be flushed. Reference: https://docs.python.org/3/library/io.html#io.IOBase.close Signed-off-by: Cleber Rosa ---

[PATCH 1/6] Python: close the log file kept by QEMUMachine before reading it

2021-02-11 Thread Cleber Rosa
Closing a file that is open for writing, and then reading from it sounds like a better idea than the opposite, given that the content will be flushed. Reference: https://docs.python.org/3/library/io.html#io.IOBase.close Signed-off-by: Cleber Rosa --- python/qemu/machine.py | 4 ++-- 1 file chang