Re: [PATCH 1/5] target/riscv/csr.c: fix deadcode in rmw_xireg()

2025-01-28 Thread Alistair Francis
On Wed, Jan 22, 2025 at 4:52 AM Daniel Henrique Barboza wrote: > > Coverity found a DEADCODE issue in rmw_xireg() claiming that we can't > reach 'RISCV_EXCP_VIRT_INSTRUCTION_FAULT' at the 'done' label: > > done: > if (ret) { > return (env->virt_enabled && virt) ? >RISCV

[PATCH 1/5] target/riscv/csr.c: fix deadcode in rmw_xireg()

2025-01-21 Thread Daniel Henrique Barboza
Coverity found a DEADCODE issue in rmw_xireg() claiming that we can't reach 'RISCV_EXCP_VIRT_INSTRUCTION_FAULT' at the 'done' label: done: if (ret) { return (env->virt_enabled && virt) ? RISCV_EXCP_VIRT_INSTRUCTION_FAULT : RISCV_EXCP_ILLEGAL_INST; } return RISCV_