Re: [PATCH 1/5] target/i386: implement special cases for fxtract

2020-06-25 Thread Peter Maydell
On Tue, 23 Jun 2020 at 23:01, Joseph Myers wrote: > > On Tue, 23 Jun 2020, Eduardo Habkost wrote: > > > > +if (EXPD(temp) == 0) { > > > +int shift = clz64(temp.l.lower); > > > +temp.l.lower <<= shift; > > > > Coverity reports the following. It looks like a false po

Re: [PATCH 1/5] target/i386: implement special cases for fxtract

2020-06-23 Thread Joseph Myers
On Tue, 23 Jun 2020, Eduardo Habkost wrote: > > +if (EXPD(temp) == 0) { > > +int shift = clz64(temp.l.lower); > > +temp.l.lower <<= shift; > > Coverity reports the following. It looks like a false positive > because floatx80_is_zero() would be true if both EXPD(te

Re: [PATCH 1/5] target/i386: implement special cases for fxtract

2020-06-23 Thread Eduardo Habkost
On Thu, May 07, 2020 at 12:43:30AM +, Joseph Myers wrote: > The implementation of the fxtract instruction treats all nonzero > operands as normal numbers, so yielding incorrect results for invalid > formats, infinities, NaNs and subnormal and pseudo-denormal operands. > Implement appropriate ha

Re: [PATCH 1/5] target/i386: implement special cases for fxtract

2020-05-15 Thread Alex Bennée
Joseph Myers writes: > The implementation of the fxtract instruction treats all nonzero > operands as normal numbers, so yielding incorrect results for invalid > formats, infinities, NaNs and subnormal and pseudo-denormal operands. > Implement appropriate handling of all those cases. > > Signed

[PATCH 1/5] target/i386: implement special cases for fxtract

2020-05-06 Thread Joseph Myers
The implementation of the fxtract instruction treats all nonzero operands as normal numbers, so yielding incorrect results for invalid formats, infinities, NaNs and subnormal and pseudo-denormal operands. Implement appropriate handling of all those cases. Signed-off-by: Joseph Myers --- target/i