Re: [PATCH 1/5] 9pfs: fix qemu_mknodat(S_IFREG) on macOS

2022-04-20 Thread Christian Schoenebeck
On Mittwoch, 20. April 2022 10:40:05 CEST Greg Kurz wrote: > On Wed, 20 Apr 2022 11:03:52 +0900 > > Akihiko Odaki wrote: > > On 2022/04/19 20:40, Christian Schoenebeck wrote: > > > mknod() on macOS does not support creating regular files, so > > > divert to openat_file() if S_IFREG is passed with

Re: [PATCH 1/5] 9pfs: fix qemu_mknodat(S_IFREG) on macOS

2022-04-20 Thread Greg Kurz
On Wed, 20 Apr 2022 11:03:52 +0900 Akihiko Odaki wrote: > On 2022/04/19 20:40, Christian Schoenebeck wrote: > > mknod() on macOS does not support creating regular files, so > > divert to openat_file() if S_IFREG is passed with mode argument. > > > > Furthermore, 'man 2 mknodat' on Linux says: "Z

Re: [PATCH 1/5] 9pfs: fix qemu_mknodat(S_IFREG) on macOS

2022-04-19 Thread Akihiko Odaki
On 2022/04/19 20:40, Christian Schoenebeck wrote: mknod() on macOS does not support creating regular files, so divert to openat_file() if S_IFREG is passed with mode argument. Furthermore, 'man 2 mknodat' on Linux says: "Zero file type is equivalent to type S_IFREG". Link: https://lore.kernel.o

Re: [PATCH 1/5] 9pfs: fix qemu_mknodat(S_IFREG) on macOS

2022-04-19 Thread Will Cohen
On Tue, Apr 19, 2022 at 8:18 AM Christian Schoenebeck < qemu_...@crudebyte.com> wrote: > mknod() on macOS does not support creating regular files, so > divert to openat_file() if S_IFREG is passed with mode argument. > > Furthermore, 'man 2 mknodat' on Linux says: "Zero file type is > equivalent t

[PATCH 1/5] 9pfs: fix qemu_mknodat(S_IFREG) on macOS

2022-04-19 Thread Christian Schoenebeck
mknod() on macOS does not support creating regular files, so divert to openat_file() if S_IFREG is passed with mode argument. Furthermore, 'man 2 mknodat' on Linux says: "Zero file type is equivalent to type S_IFREG". Link: https://lore.kernel.org/qemu-devel/17933734.zYzKuhC07K@silver/ Signed-off