Alistair Francis writes:
> Reviewed-by: Alistair Francis
Thanks much. I think we'll need some help getting the next two patches
reviewed; that touches ARM code. The last patch is also RISC-V only.
--
-keith
signature.asc
Description: PGP signature
On Wed, Oct 28, 2020 at 11:57 AM Keith Packard via
wrote:
>
> This commit renames two files which provide ARM semihosting support so
> that they can be shared by other architectures:
>
> 1. target/arm/arm-semi.c -> hw/semihosting/common-semi.c
> 2. linux-user/arm/semihost.c -> linux-user/sem
Alex Bennée writes:
> specific_ss.add(when: 'CONFIG_ARM_STYLE_SEMIHOSTING',
> if_true: files ('common-semi.c'))
I've sent another version of the series using this plan. It does look a
bit nicer as the only changes required when adding support to another
target is to place thi
This commit renames two files which provide ARM semihosting support so
that they can be shared by other architectures:
1. target/arm/arm-semi.c -> hw/semihosting/common-semi.c
2. linux-user/arm/semihost.c -> linux-user/semihost.c
The build system was modified use a new config variable,
CONF
Alex Bennée writes:
> I don't think we want arm specific adds in the common code. I think what
> Peter was suggesting is a new config symbol that only ARM and RISC
> define, e.g something like:
>
> specific_ss.add(when: 'CONFIG_ARM_STYLE_SEMIHOSTING',
> if_true: files ('common
Peter Maydell writes:
>> arm_ss.add(when: 'CONFIG_TCG', if_true: files ('common-semi.c'))
>> riscv_ss.add(files('common-semi.c'))
>>
>> This appears to work in my testing (building arm, risc-v and x86_64
>> configs).
>
> I'm not a kconfig expert but it might be preferable to have
On Tue, 27 Oct 2020 at 21:56, Keith Packard wrote:
>
> Peter Maydell writes:
>
> >> +specific_ss.add(when: 'CONFIG_TCG', if_true: files ('common-semi.c'))
> >
> > I think this adds this file to the compilation for all TCG targets;
> > you only want it for targets which have Arm-semihosting-ABI co
Peter Maydell writes:
>> +specific_ss.add(when: 'CONFIG_TCG', if_true: files ('common-semi.c'))
>
> I think this adds this file to the compilation for all TCG targets;
> you only want it for targets which have Arm-semihosting-ABI compatible
> semihosting. (Various other targets either don't have
On Mon, 26 Oct 2020 at 21:29, Keith Packard wrote:
>
> This commit renames two files which provide ARM semihosting support so
> that they can be shared by other architectures:
>
> 1. target/arm/arm-semi.c -> hw/semihosting/common-semi.c
> 2. linux-user/arm/semihost.c -> linux-user/semihost.c
On Mon, Oct 26, 2020 at 2:34 PM Keith Packard via wrote:
>
> This commit renames two files which provide ARM semihosting support so
> that they can be shared by other architectures:
>
> 1. target/arm/arm-semi.c -> hw/semihosting/common-semi.c
> 2. linux-user/arm/semihost.c -> linux-user/semi
This commit renames two files which provide ARM semihosting support so
that they can be shared by other architectures:
1. target/arm/arm-semi.c -> hw/semihosting/common-semi.c
2. linux-user/arm/semihost.c -> linux-user/semihost.c
The build system was modified to reflect this change, but the
11 matches
Mail list logo
