Re: [PATCH 1/4] migration/savevm: Add a compatibility check for capabilities

2025-04-11 Thread Fabiano Rosas
Fabiano Rosas writes: > Fabiano Rosas writes: > > +Cc Markus > > context: > This series was trying to stop savevm from crashing when arbitrary > migration capabilities are enabled. Daniel brought up the previous > discussion around unifying capabilities + parameters and passing it all > via the

Re: [PATCH 1/4] migration/savevm: Add a compatibility check for capabilities

2025-04-07 Thread Fabiano Rosas
Fabiano Rosas writes: +Cc Markus context: This series was trying to stop savevm from crashing when arbitrary migration capabilities are enabled. Daniel brought up the previous discussion around unifying capabilities + parameters and passing it all via the migrate (or snapshot in this case) comma

Re: [PATCH 1/4] migration/savevm: Add a compatibility check for capabilities

2025-04-05 Thread Fabiano Rosas
"Marco Cavenati" writes: > Hello Fabiano, > > First of all thanks a lot for the quick follow up to my issue! > > I just want to point out that with only mapped-ram enabled (without > multifd) savevm/loadvm do not lead to a crash but just to an error > according to my (few) experiments (on upstrea

Re: [PATCH 1/4] migration/savevm: Add a compatibility check for capabilities

2025-04-04 Thread Fabiano Rosas
Fabiano Rosas writes: > Daniel P. Berrangé writes: > >> On Thu, Mar 27, 2025 at 11:39:31AM -0300, Fabiano Rosas wrote: >>> It has always been possible to enable arbitrary migration capabilities >>> and attempt to take a snapshot of the VM with the savevm/loadvm >>> commands as well as their QMP

Re: [PATCH 1/4] migration/savevm: Add a compatibility check for capabilities

2025-03-27 Thread Marco Cavenati
Hello Fabiano, First of all thanks a lot for the quick follow up to my issue! I just want to point out that with only mapped-ram enabled (without multifd) savevm/loadvm do not lead to a crash but just to an error according to my (few) experiments (on upstream). Ciao Marco On Thursday, March 27

Re: [PATCH 1/4] migration/savevm: Add a compatibility check for capabilities

2025-03-27 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Thu, Mar 27, 2025 at 11:39:31AM -0300, Fabiano Rosas wrote: >> It has always been possible to enable arbitrary migration capabilities >> and attempt to take a snapshot of the VM with the savevm/loadvm >> commands as well as their QMP counterparts >> snapshot-save/s

Re: [PATCH 1/4] migration/savevm: Add a compatibility check for capabilities

2025-03-27 Thread Daniel P . Berrangé
On Thu, Mar 27, 2025 at 11:39:31AM -0300, Fabiano Rosas wrote: > It has always been possible to enable arbitrary migration capabilities > and attempt to take a snapshot of the VM with the savevm/loadvm > commands as well as their QMP counterparts > snapshot-save/snapshot-load. > > Most migration c

[PATCH 1/4] migration/savevm: Add a compatibility check for capabilities

2025-03-27 Thread Fabiano Rosas
It has always been possible to enable arbitrary migration capabilities and attempt to take a snapshot of the VM with the savevm/loadvm commands as well as their QMP counterparts snapshot-save/snapshot-load. Most migration capabilities are not meant to be used with snapshots and there's a risk of c